Closed
Bug 912699
Opened 11 years ago
Closed 11 years ago
improve load source error messages
Categories
(DevTools :: Debugger, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 26
People
(Reporter: fitzgen, Assigned: fitzgen)
Details
Attachments
(1 file)
3.49 KB,
patch
|
past
:
review+
|
Details | Diff | Splinter Review |
The messages we get from the server when we try to load sources but it fails are pretty bad. We should improve them. https://tbpl.mozilla.org/?tree=Try&rev=a698710ded25
Attachment #799750 -
Flags: review?(past)
Comment 1•11 years ago
|
||
Comment on attachment 799750 [details] [diff] [review] source-errors.patch Review of attachment 799750 [details] [diff] [review]: ----------------------------------------------------------------- ::: toolkit/devtools/server/actors/script.js @@ +3769,5 @@ > }, > onStopRequest: function(aRequest, aContext, aStatusCode) { > if (!Components.isSuccessCode(aStatusCode)) { > + deferred.reject(new Error("Request failed in onStopRequest. url = " + url > + + ", status code = " + aStatusCode)); Wouldn't it be better to have something like "Request failed with status = 35 in onFooHandler for url = http://blah"?
Attachment #799750 -
Flags: review?(past) → review+
Assignee | ||
Comment 2•11 years ago
|
||
Updated and pushed. https://hg.mozilla.org/integration/fx-team/rev/a72b2b8b82df
Whiteboard: [fixed-in-fx-team]
Comment 3•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/a72b2b8b82df
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 26
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•