912800 - excluding non-shipped files from the checksums files

Status: RESOLVED FIXED

(Release Engineering :: Release Automation: Other, defect, P3)

Description

[Rail Aliiev [:rail]]

In bug 785392 we started uploading mar/bsdiff binaries and in bug 898099 enabled this behavior for betas.

Generated checksums don't represent files' real location on FTP and contain file name collisions:

7038afc271061c62f4442f7a78c22d66  host/bin/mar
63a351cd6d25b8da073ac1008d6b4964  host/bin/mar
fd46c8c10f2661ce5f3d311a6d910724  host/bin/mar
404b1ef69b1fbe6bf495227af268c186  host/bin/mar.exe
6de5a371b9ee5ea71b6d67ab29b5764c  host/bin/mbsdiff
f3d3efb40eadd7e547a5bc91525922b5  host/bin/mbsdiff
3d4fe03503f5a6a964b78879c1a52978  host/bin/mbsdiff
ffd0fe677c1520a65206ebdcaa2a0546  host/bin/mbsdiff.exe

Comment 1

[Nick Thomas [:nthomas] (UTC+12)]

Are these really shipping files ? I mean I see them in http://stage.mozilla.org/pub/mozilla.org/firefox/releases/24.0b8/mar-tools/ but is that just an oversight in the push to mirrors job ?

Comment 2

[Rail Aliiev [:rail]]

(In reply to Nick Thomas [:nthomas] from comment #1)
> Are these really shipping files ? I mean I see them in
> http://stage.mozilla.org/pub/mozilla.org/firefox/releases/24.0b8/mar-tools/
> but is that just an oversight in the push to mirrors job ?

I filed bug 912823.

Comment 3

[[e-mail] (:bhearsum)]

(In reply to Rail Aliiev [:rail] from comment #2)
> (In reply to Nick Thomas [:nthomas] from comment #1)
> > Are these really shipping files ? I mean I see them in
> > http://stage.mozilla.org/pub/mozilla.org/firefox/releases/24.0b8/mar-tools/
> > but is that just an oversight in the push to mirrors job ?
> 
> I filed bug 912823.

That makes this bug WONTFIX, right?

Comment 4

[Nick Thomas [:nthomas] (UTC+12)]

I don't think so. The change to DEFAULT_RSYNC_EXCLUDES in stage-tasks.py doesn't exclude mar-tools from the checksumming process.

Comment 5

[Nick Thomas [:nthomas] (UTC+12)]

Actually, there's a more general bug about excluding non-shipped files from the checksums files. Other examples include jsshell, *info.txt, win32/*/*.zip.

Comment 6

[Rail Aliiev [:rail]]

beetmover FTW!