Closed
Bug 912931
Opened 11 years ago
Closed 11 years ago
With apz enabled, clicking the bookmark button triggers double input events
Categories
(Core Graveyard :: Widget: WinRT, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla26
People
(Reporter: jimm, Assigned: jimm)
References
Details
Attachments
(2 files)
7.29 KB,
patch
|
Details | Diff | Splinter Review | |
1.03 KB,
patch
|
bbondy
:
review+
|
Details | Diff | Splinter Review |
STR: 1) enable apz 2) visit a page 3) click the bookmark button result: the button will depress indicating a bookmark was added, then a split second later return to it's normal state, indicating the bookmark was removed. This may be a side effect of bug 907410 as well, since I have that in my patch queue.
Assignee | ||
Comment 1•11 years ago
|
||
I think we need a fix to this before we turn on apz. Also checked, this isn't related to bug 907410.
Blocks: 898055
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → jmathies
Assignee | ||
Comment 2•11 years ago
|
||
Assignee | ||
Updated•11 years ago
|
Attachment #800179 -
Flags: review?(bugmail.mozilla)
Assignee | ||
Comment 3•11 years ago
|
||
We might come back to using this in time as we work on our input process but for the time being I'd prefer to rely on the built-in support we get from the Winrt GestureRecognizer class.
Comment 4•11 years ago
|
||
You don't actually need the changes to GestureEventListener* here, do you? Stubbing out the callbacks in MetroWidget should be sufficient. I'm a little leery of disabling pieces of the gesture code because it's easy to miss something and leave the internal state inconsistent.
Assignee | ||
Comment 5•11 years ago
|
||
(In reply to Kartikaya Gupta (email:kats@mozilla.com) from comment #4) > You don't actually need the changes to GestureEventListener* here, do you? > Stubbing out the callbacks in MetroWidget should be sufficient. I'm a little > leery of disabling pieces of the gesture code because it's easy to miss > something and leave the internal state inconsistent. I'm not a fan of the added overhead this creates, But I can live with it if you really don't want GestureEventListener configurable.
Assignee | ||
Comment 6•11 years ago
|
||
Attachment #800313 -
Flags: review?(netzen)
Assignee | ||
Updated•11 years ago
|
Attachment #800179 -
Flags: review?(bugmail.mozilla)
Updated•11 years ago
|
Attachment #800313 -
Flags: review?(netzen) → review+
Comment 7•11 years ago
|
||
(In reply to Jim Mathies [:jimm] from comment #5) > I'm not a fan of the added overhead this creates, But I can live with it if > you really don't want GestureEventListener configurable. I'm not either, but I think the longer term solution is to move the detection for those tap events out of APZC-land and into gecko.
Comment 8•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/4b03903fb8f5
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
Updated•10 years ago
|
OS: Windows 8 Metro → Windows 8.1
Updated•5 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•