Closed
Bug 912996
Opened 11 years ago
Closed 11 years ago
Don't do memcpy in UnixSocketImpl::OnFileCanReadWithoutBlocking
Categories
(Core :: IPC, defect)
Tracking
()
RESOLVED
FIXED
mozilla26
People
(Reporter: tzimmermann, Assigned: tzimmermann)
Details
Attachments
(2 files)
5.42 KB,
patch
|
qdot
:
review+
|
Details | Diff | Splinter Review |
5.48 KB,
patch
|
qdot
:
review+
|
Details | Diff | Splinter Review |
The is a big, fat 16KiB memcpy right in the middle of UnixSocketImpl::OnFileCanReadWithoutBlocking. Let's get rid of it.
Assignee | ||
Comment 1•11 years ago
|
||
It's actually 64 KiB.
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → tzimmermann
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•11 years ago
|
||
Attachment #800247 -
Flags: review?(kyle)
Assignee | ||
Comment 3•11 years ago
|
||
Attachment #800248 -
Flags: review?(kyle)
Assignee | ||
Comment 4•11 years ago
|
||
Tested on my Unagi.
Updated•11 years ago
|
Attachment #800247 -
Flags: review?(kyle) → review+
Updated•11 years ago
|
Attachment #800248 -
Flags: review?(kyle) → review+
Assignee | ||
Comment 5•11 years ago
|
||
Thanks! https://hg.mozilla.org/integration/b2g-inbound/rev/329b5c56525a https://hg.mozilla.org/integration/b2g-inbound/rev/8a03f671fd11 https://tbpl.mozilla.org/?tree=B2g-Inbound&rev=8a03f671fd11
Comment 6•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/329b5c56525a https://hg.mozilla.org/mozilla-central/rev/8a03f671fd11
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in
before you can comment on or make changes to this bug.
Description
•