913829 - Force vertical layout when the tools are docked in the sidebar

Status: RESOLVED INACTIVE

(DevTools :: General, defect, P3)

Comment 1

[Paul Rouget [:paul]]

It's very annoying to have the tools change layout on resize when docked in the sidebar.

I was looking at Darrin when he was working with our tools on a design, and he kept resizing the toolbox. I could feel the frustration every time he was reaching these 700px limit.

When we resize horizontally our tools, it's often to have more room to see CSS code or the DOM tree.

Let not change the layout when the host is the sidebar.

Comment 2

[Paul Rouget [:paul]]

Attachment: patch v0.1

I'm not happy with this patch.
It's a lot of code duplication.

And it doesn't work well with the network monitor, I'm not sure why.

Victor, any better idea of how we could fix that?

Comment 3

[Victor Porof [:vporof][:vp]]

Comment on attachment 801134 [details] [diff] [review]
patch v0.1

Review of attachment 801134 [details] [diff] [review]:
-----------------------------------------------------------------

The netmonitor makes sure the columns have different proportional dimensions, all based on the available width. I agree this is a lot of code duplication, I would hate it if we'd be forced to land this.

Since the problem described above is mostly prominent when working in the Inspector, for I vote for not changing the Netmonitor at all. I think the current style hooks and responsive columns are enough to not annoy people.

Comment 4

[Paul Rouget [:paul]]

I won't be working on that anytime soon.