913845 - Filtering IonSpew with IONFILTER env var broken

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Yves Gwerder]

Attachment: IONFILTER_fix.diff

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:23.0) Gecko/20100101 Firefox/23.0 (Beta/Release)
Build ID: 20130803192641

Steps to reproduce:

Set the IONFILTER environment variable to a specific function using export IONFILTER=filename.js:1234.




Actual results:

IonSpew won't output anything even though the function is Ion compiled.


Expected results:

Ion.cfg and Ion.json in /tmp should contain data for the SSA graphs.

Comment 1

[Yves Gwerder]

The reason for this issue is that the static keyword is used for the filelen (check the attached patch).
It will always contain the first value assigned but it should contain the length of the current filename.

Comment 2

[Hannes Verschore [:h4writer]]

Comment on attachment 801143 [details] [diff] [review]
IONFILTER_fix.diff

Review of attachment 801143 [details] [diff] [review]:
-----------------------------------------------------------------

Nice find

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/17abba1ddb3f

Thanks for the patch, Yves! One request, please make sure that you configure Hg to generate patches will all the needed metadata for checkin. Makes life easier for those landing on your behalf. Thanks!
https://developer.mozilla.org/en-US/docs/Mercurial_FAQ#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3F

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/17abba1ddb3f