913964 - Don't show 'Ignore Thread', 'Ignore Subthread', and 'Watch Thread' menu items on non-mail, special tabs like 'Troubleshooting information'

Status: RESOLVED FIXED

(Thunderbird :: Toolbars and Tabs, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Thunderbird 24.0b2, Daily 20130904030204

Don't show 'Ignore Thread', 'Ignore Subthread', and 'Watch Thread' menu items on non-mail, special tabs like 'Troubleshooting information'.

Comment 1

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: patch, v1

[Approval Request Comment]
Regression caused by (bug #): bug 179033
User impact if declined: Context menu in non-mail tabs shows "Ignore Thread", "Ignore Subthread", "Watch Thread" (haven't tested what happens if you click on them)
Testing completed (on c-c, etc.): no
Risk to taking this patch (and alternatives if risky): [If the context menus match]: None.

Comment 2

[Mark Banner (:standard8)]

https://hg.mozilla.org/comm-central/rev/52ce01123f03

Comment 3

[Mark Banner (:standard8)]

https://hg.mozilla.org/releases/comm-aurora/rev/8784f3689533
https://hg.mozilla.org/releases/comm-beta/rev/02fdbdf2c518

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: also hide separator, patch, v1

I hadn't added the new separator to the list of separators, so it gets shown at the end of the menu. This patch hides it.

I will file a bug to remove this static separator list in later Thunderbird versions.

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

(In reply to Archaeopteryx [:aryx] from comment #4)
> I will file a bug to remove this static separator list in later Thunderbird
> versions.
Filed as bug 916482.

Comment 6

[Mark Banner (:standard8)]

Comment on attachment 804900 [details] [diff] [review]
also hide separator, patch, v1

Looks good, but if we want this on branches, please move the patch to a separate bug so we can use the tracking flags appropriately.