914050 - Main window announced to VoiceOver as "unknown"

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Marco Zehe (:MarcoZ)]

The main window for Firefox is no longer being announced to VoiceOver as a window, but as an "unknown". Something broke the AXROLE string for the main window.

STR: 1. With VoiceOver on, start Nightly.
2. Explore the top-most elements. You have a close button, a minimize and a zoom button, and then you have an "unknown" with the current window title spoken.
You can interact with it and use all child elements, but the window itself is no longer a real window in the VoiceOver/Universal Access sense. Accessibility Inspector will probably also show a failure here.

Comment 1

[Marco Zehe (:MarcoZ)]

Attachment: Main window announced to VoiceOver as unknown,

Comment 2

[Marco Zehe (:MarcoZ)]

Note that the actually correct fix for this bug would be not to expose the ChromeWindow accessible at all, and to expose its direct children as top level items for VoiceOver in the Firefox window instead. This is how all other OS X apps appear. However, since I don't know how to accomplish that, I remapped the ChromeWindow to be exposed as a group rather than an unknown. Note that window didn't work, that ate all the children except the HTML content.

Comment 3

[alexander :surkov (:asurkov)]

Comment on attachment 801566 [details] [diff] [review]
Main window announced to VoiceOver as unknown,

Review of attachment 801566 [details] [diff] [review]:
-----------------------------------------------------------------

it's reasonable, r=me

Comment 4

[Marco Zehe (:MarcoZ)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/07ff0d3d9c40

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/07ff0d3d9c40