Closed
Bug 914324
Opened 11 years ago
Closed 11 years ago
"JavaScript strict warning: chrome://browser/content/browser.js, line 5886: assignment to undeclared variable SocialStatus" warning in debug build startup output
Categories
(Firefox Graveyard :: SocialAPI, defect)
Firefox Graveyard
SocialAPI
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 26
People
(Reporter: RyanVM, Assigned: dholbert)
References
Details
Attachments
(2 files)
875 bytes,
patch
|
mixedpuppy
:
review+
|
Details | Diff | Splinter Review |
802 bytes,
patch
|
dholbert
:
review+
|
Details | Diff | Splinter Review |
Noticed this in some Jetpack test logs recently. Figured it was worth filing. https://tbpl.mozilla.org/php/getParsedLog.php?id=27572876&tree=Mozilla-Inbound JavaScript strict warning: chrome://browser/content/browser.js, line 5886: assignment to undeclared variable SocialStatus
Assignee | ||
Comment 2•11 years ago
|
||
Assignee | ||
Comment 3•11 years ago
|
||
(In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #0) > Noticed this in some Jetpack test logs recently. Figured it was worth filing. I think we hit this in all debug builds. I see it in my startup-spew of my local debug build -- it's the ~10th line of output on my system (intermixed with some "++DOMWINDOW" lines).
Summary: "JavaScript strict warning: chrome://browser/content/browser.js, line 5886: assignment to undeclared variable SocialStatus" warning in Jetpack logs → "JavaScript strict warning: chrome://browser/content/browser.js, line 5886: assignment to undeclared variable SocialStatus" warning in debug build startup output
Assignee | ||
Updated•11 years ago
|
OS: Mac OS X → All
Hardware: x86_64 → All
Version: unspecified → Trunk
Comment 4•11 years ago
|
||
Comment on attachment 801756 [details] [diff] [review] fix: add "let" to declare the variable :( Hi Daniel, Add SocialStatus to the let list at the top of browser-social.js (it needs to be global due to the button oncommand). r=me with that. Shane
Attachment #801756 -
Flags: review?(mixedpuppy) → review+
Assignee | ||
Comment 5•11 years ago
|
||
Gotcha. Thanks for the r+! inbound is currently closed, so I'm posting the updated patch as checkin-needed.
Attachment #801807 -
Flags: review+
Attachment #801807 -
Flags: checkin?
Assignee | ||
Updated•11 years ago
|
Keywords: checkin-needed
Assignee | ||
Comment 6•11 years ago
|
||
Inbound's open again, so I landed: https://hg.mozilla.org/integration/mozilla-inbound/rev/a9ccc26e524b
Flags: in-testsuite-
Keywords: checkin-needed
Assignee | ||
Updated•11 years ago
|
Attachment #801807 -
Flags: checkin?
Comment 8•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/a9ccc26e524b
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 26
Updated•5 years ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•