914382 - [Settings] Add some improvements to Gaia about how it handles the new APN architecture.

Status: RESOLVED INVALID

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[José Antonio Olivera Ortega [:jaoo]]

I've noticed this issue while setting up data calls with the SIMs provided by Telenor during the Oslo WW.

When device boots the system app stores the APN settings into the setting database under the `ril.data.apnSettings` key with the following value:

I/Gecko   ( 1080): -*- RadioInterface[0]: 'ril.data.apnSettings' is now [[{"carrier":"Ventelo Internett","apn":"internet.ventelo.no","types":["default","supl"]},{"carrier":"Ventelo MMS","apn":"mms.ventelo.no","user":"ventelo","password":"1111","mmsc":"http://mmsc/","mmsproxy":"10.10.10.11","mmsport":"8080","types":["mms"]}]]

If the user goes to the APN setting panel in the setting app and selects the APNs for Telenor carrier the APN settings into the setting database under the `ril.data.apnSettings` changes to:

I/Gecko   ( 1080): -*- RadioInterface[0]: 'ril.data.apnSettings' is now [[{"apn":"telenor","user":"","password":"","proxy":"","port":"","authtype":"notDefined","types":["default"]},{"carrier":"Ventelo Internett","apn":"internet.ventelo.no","types":["supl"]},{"carrier":"Ventelo MMS","apn":"mms.ventelo.no","user":"ventelo","password":"1111","mmsc":"http://mmsc/","mmsproxy":"10.10.10.11","mmsport":"8080","types":["mms"]}]]

As you can see guys we are mixing the APN setting from two different carriers and that's wrong. If the user changes to use the APN settings for data calls the APN settings for both MMS and SUPL must change as well.

Comment 1

[Ken Chang[:kenkai]]

(In reply to José Antonio Olivera Ortega [:jaoo] from comment #0)
> As you can see guys we are mixing the APN setting from two different
> carriers and that's wrong. If the user changes to use the APN settings for
> data calls the APN settings for both MMS and SUPL must change as well.
I wonder if this bug comes from Gaia's design. It isn't related to the change
of APN setting.
In old APN setting architecture, when user selects carriers' APN settings for default type
in the APN setting, Gaia only sends the default APN Settings to RIL.

I deam that we should change the Gaia design. When user selects carriers' APN settings from
database, we have to base on that selected carriers' APN settings to update "default", "mms",
"supl",.. at the same time.

Comment 2

[José Antonio Olivera Ortega [:jaoo]]

(In reply to Ken Chang from comment #1)
> (In reply to José Antonio Olivera Ortega [:jaoo] from comment #0)
> > As you can see guys we are mixing the APN setting from two different
> > carriers and that's wrong. If the user changes to use the APN settings for
> > data calls the APN settings for both MMS and SUPL must change as well.
> I wonder if this bug comes from Gaia's design.

Yes, I handle this bug on Gaia side. There is no issue in the RIL plumbing.

Comment 3

[José Antonio Olivera Ortega [:jaoo]]

WIP branch at https://github.com/jaoo/gaia/tree/914382

Comment 4

[José Antonio Olivera Ortega [:jaoo]]

(In reply to José Antonio Olivera Ortega [:jaoo] from comment #0)

> As you can see guys we are mixing the APN setting from two different
> carriers and that's wrong. If the user changes to use the APN settings for
> data calls the APN settings for both MMS and SUPL must change as well.

After thinking a bit more about this bug I realize that if the user changes the APN for data calls the APN for both MMS and SUPL should not change as well because we must set the APN the user prefer and if we change transparently the APN for MMS and SUPL it might be confusing to the user.

I'll add some improvements to Gaia about how it handles the new APN architecture. So I'll change the bug tittle as well.

IHMO the UX for the APN settings in the setting app should be revised and a new UX should be proposed since the APN architecture underneath has changed and it makes so difficult to do things right and clean. Would be that possible please? Thanks!

Comment 5

[José Antonio Olivera Ortega [:jaoo]]

Ooops, forgot to request ni? at Neo and Maria. Could you take a look at comment #4 (last paragraph) please? Thanks!

Comment 6

[Neo Hsieh [:neo]]

Hi José, Thanks for your information. 
My suggestion is let APN setting changed by SET. Not just change internet APN. 
Because most of users & carriers, they only have one set of APN for one SIM card. 
It's too complex to let user know what is APN or tell them if you change the APN setting, you only change the internet APN setting. That will be advance setting for users.

Comment 7

[minimeri]

Attachment: APN settings UX

Hi Jose!
Sorry for the delay of my answer, i've attached  my proposal for the UX for the new APN settings. 

Do no hesitate to ask me any question :)

Comment 8

[José Antonio Olivera Ortega [:jaoo]]

I'll take care of the UI change in bug 969298 so I close this.