914403 - B2G highlighter remains visible after closing toolbox

Status: RESOLVED FIXED

(DevTools :: Inspector, defect)

Description

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

STR:
1. Connect to device with App Manager
2. Debug an app
3. Pick some element with the Inspector
4. Close toolbox
5. The highlighter is still displayed in the app

Comment 1

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: Part 1: Fix explicit selection removal with remote highlighter

This cleans up a flawed part of the basic highlighter test.  The call to selection.setNode(null) would fail because walker.highlight would blow up when passing null to _installHelperSheet.

Comment 2

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: Part 2: Convert basic highlighter test to Task.jsm

I've converted this test to use Task.jsm.  It makes it generally easier to read and simpler to extend in part 3.

Comment 3

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: Part 3: Clear selection on remote inspector destuction

This fixes the main issue mentioned in comment #0.  The highlighter would correctly disappear after it timed out, but if you closed the toolbox before the timeout fired, the highlighter would remain forever.

This forces the selection to be cleared on inspector destruction.

Comment 4

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Try push: https://tbpl.mozilla.org/?tree=Try&rev=8162791df2e0

Comment 5

[Paul Rouget [:paul]]

https://hg.mozilla.org/integration/fx-team/rev/67fb445b85a3
https://hg.mozilla.org/integration/fx-team/rev/022b9b96a7f4
https://hg.mozilla.org/integration/fx-team/rev/fe907af7bc8d

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/fe907af7bc8d
https://hg.mozilla.org/mozilla-central/rev/022b9b96a7f4
https://hg.mozilla.org/mozilla-central/rev/67fb445b85a3

Comment 7

[Paul Rouget [:paul]]

Comment on attachment 805716 [details] [diff] [review]
Part 1: Fix explicit selection removal with remote highlighter

[Approval Request Comment]
Bug caused by (feature/regressing bug #): new feature (app manager)
User impact if declined: red outline around elements on Firefox OS after debugging an app
Testing completed (on m-c, etc.): m-c
Risk to taking this patch (and alternatives if risky): low
String or IDL/UUID changes made by this patch: no

Comment 8

[Paul Rouget [:paul]]

Comment on attachment 805718 [details] [diff] [review]
Part 2: Convert basic highlighter test to Task.jsm

[Approval Request Comment]
Bug caused by (feature/regressing bug #): new feature (app manager)
User impact if declined: red outline around elements on Firefox OS after debugging an app
Testing completed (on m-c, etc.): m-c
Risk to taking this patch (and alternatives if risky): low
String or IDL/UUID changes made by this patch: no

Comment 9

[Paul Rouget [:paul]]

Comment on attachment 805721 [details] [diff] [review]
Part 3: Clear selection on remote inspector destuction

[Approval Request Comment]
Bug caused by (feature/regressing bug #): new feature (app manager)
User impact if declined: red outline around elements on Firefox OS after debugging an app
Testing completed (on m-c, etc.): m-c
Risk to taking this patch (and alternatives if risky): low
String or IDL/UUID changes made by this patch: no

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/b7c012b45bf6
https://hg.mozilla.org/releases/mozilla-aurora/rev/a72a845b6892
https://hg.mozilla.org/releases/mozilla-aurora/rev/6dedfabac690