914659 - B2G RIL: Writing marionette test for removing ICC Contact

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: RIL, defect)

Description

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Currently in marionette tests for icc contact, we only test reading and adding.
We also need to have tests for removing.

Comment 1

[Georgia Wang]

Attachment: Add remove contact marionette test.

https://tbpl.mozilla.org/?tree=Try&rev=e00448b275aa

Comment 2

[Georgia Wang]

Attachment: Add remove contact marionette test.

Comment 3

[Georgia Wang]

Here's the try result:
https://tbpl.mozilla.org/?tree=Try&rev=42eb76f0d655

Comment 4

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Comment on attachment 828556 [details] [diff] [review]
Add remove contact marionette test.

Review of attachment 828556 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/icc/tests/marionette/test_icc_contact.js
@@ +99,5 @@
> +  updateRequest.onsuccess = function onsuccess() {
> +    if (type === "fdn" && pin2 === undefined) {
> +      ok(false, "Should not update fdn when pin2 is not provided");
> +      runNextTest();
> +    }

I don't understand what you're tring to do here.

@@ +108,5 @@
> +    getRequest.onsuccess = function onsuccess() {
> +      let contacts = getRequest.result;
> +
> +      // There are 4 SIM contacts which are harded in emulator
> +      is(contacts.length, 4);

What's this check for ?

@@ +159,5 @@
> +  testRemoveContact("fdn");
> +}
> +
> +function testRemoveFdnContactWithoutPassingPin2() {
> +  testRemoveContact("fdn", "0000");

WithPassingPin2?

what's "0000" here?

Comment 5

[Georgia Wang]

(In reply to Yoshi Huang[:allstars.chh][:yoshi] from comment #4)
> Comment on attachment 828556 [details] [diff] [review]
> Add remove contact marionette test.
> 
> Review of attachment 828556 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: dom/icc/tests/marionette/test_icc_contact.js
> @@ +99,5 @@
> > +  updateRequest.onsuccess = function onsuccess() {
> > +    if (type === "fdn" && pin2 === undefined) {
> > +      ok(false, "Should not update fdn when pin2 is not provided");
> > +      runNextTest();
> > +    }
> 
> I don't understand what you're tring to do here.
There's no check for: no pin2 but update FDN case. 
like Bug 935399. So I want to add test for this part.


> @@ +108,5 @@
> > +    getRequest.onsuccess = function onsuccess() {
> > +      let contacts = getRequest.result;
> > +
> > +      // There are 4 SIM contacts which are harded in emulator
> > +      is(contacts.length, 4);
> 
> What's this check for ?
In previous test, we add contact id = 5 in both ADN and FDN.
So if we remove contactId = 5, there should be only 4 contacts as default.

> @@ +159,5 @@
> > +  testRemoveContact("fdn");
> > +}
> > +
> > +function testRemoveFdnContactWithoutPassingPin2() {
> > +  testRemoveContact("fdn", "0000");
> 
> WithPassingPin2?
> 
> what's "0000" here?

Sorry, the name should be switch between the two functions.

Since the code here has some change for multiple ICCs, I made some change and will update patch later.

Comment 6

[Georgia Wang]

Attachment: Add remove contact marionette test. v2

Comment 7

[Georgia Wang]

TRY https://tbpl.mozilla.org/?tree=Try&rev=176384bcf49f

Comment 8

[Ken Chang[:kenkai]]

Add this in backlog.

Comment 9

[John Dai[:jdai]]

No longer work on this.