91466 - Unknown CA alert is horked

Status: VERIFIED FIXED

(Core Graveyard :: Security: UI, defect, P2)

Description

[Matthew T (active 1999-2002)]

Build: 2001071804, Mac OS 9.1

To reproduce:
1.  Go to an URL which uses a secure certificate for which Mozilla does not
    recognize the CA.

What you see:
+-----------------------------------------------------+
|::::::::::::: Security Error: Unknown CA ::::::::::::|
+-----------------------------------------------------+
| "monitor.inter-touch.net" is a web site that uses a |
| security certificate to identify itself. However,   |
| Mozilla does not recognize the Certificate          |
| Authority that issued this certificate.             |
|                                                     |
| Although the Certificate Authority is unrecognized, |
| you can choose to explicitly accept the certificate |
| used by this web site.                              |
|                                                     |
| Before accepting this certificate, you should       |
| examine this site's certificate carefully.          |
|                                                     |
| Are you willing to accept this certificate for the  |
| purpose of identifying the web site                 |
| "monitor.inter-touch.net"?                          |
|                                                     |
| ( ) Accept this certificate permanently             |
| (*) Accept this certificate temporarily for this    |
|     session                                         |
| ( ) Do not accept this certificate and do not       |
|     connect to this web site                        |
| ( View Certificate )                                |
|                                                     |
| (   OK   ) ( Cancel ) (  Help  )                    |
|                                                     |
|                                                     |
|                                                     |
|                                                     |
|                                                     |
+-----------------------------------------------------+

What was expected:
*   An alert which looks like an alert, i.e. one which uses the /!\ icon and
    does not have a title.
*   Text short enough for people to bother reading, instead of coming to the
    counter and asking me for help.
*   Buttons, not radio buttons, used for commands.
*   `OK' and `Cancel' buttons in the correct order and in the right corner of
    the alert.
*   Only 12 pixels space between the bottom of the `Cancel' button and the
    bottom of the alert, not 40 pixels (see also bug 85809).

What you should see:

+-----------------------------------------------------+
|:::::::::::::::::::::::::::::::::::::::::::::::::::::|
+-----------------------------------------------------+
|   .   There is a problem with the security          |
|  /!\  certificate for "monitor.inter-touch.net".    |
|  """  Do you want to continue?                      |
|                                                     |
|       (X) The certificate was issued by a           |
|           Certificate Authority which Mozilla does  |
|           not recognize.                            |
|                                                     |
|                               ( View _Certificate ) |
|                                                     |
|       [ ] Remember this decision for _all           |
|           certificates from www.inter-touch.net     |
|                                                     |
| [?]                       ( Cancel ) (( Continue )) |
+-----------------------------------------------------+

Comment 1

[timeless]

personally i'd like a 
[ ] Remember this decision for all certificates with this _problem

Comment 2

[Matthew T (active 1999-2002)]

If that checkbox was a good idea, we shouldn't be putting up this alert at all 
in the first place.

Comment 3

[Håkan Waara]

Note to bug owner: I am trying to fix this...

Comment 4

[Gervase Markham [:gerv]]

In which case, you can have it :-) If you stop working on it, assign it back to 
me.

Gerv

Comment 5

[Håkan Waara]

Here is the new spec I and mpt came up with during an IRC session (some
tradeoffs made, but overall, it's as good as the previous one IMHO):

+-----------------------------------------------------+
|:::::::::::::::::::::::::::::::::::::::::::::::::::::|
+-----------------------------------------------------+
|   .   There is a problem with the security          |
|  /!\  certificate for "monitor.inter-touch.net".    |
|  """  Do you want to continue?                      |
|                                                     |
|       The certificate was issued by a               |
|       Certificate Authority which Mozilla does      |
|       not recognize.                                |
|                                                     |
|                               ( View _Certificate ) |
|                                                     |
|       [ ] Always accept this certificate            |
|                                                     |
| ( Help )                  ( Cancel ) (( Continue )) |
+-----------------------------------------------------+

I'm working hard on implementing every detail. It'll look gorgeous once it's
finished!

Comment 6

[Håkan Waara]

Ok, here goes...

Comment 7

[Håkan Waara]

Attachment: Before (screenshot)

Comment 8

[Håkan Waara]

Attachment: Before (Erh, attach as GIF this time)

Comment 9

[Håkan Waara]

Attachment: After (screenshot)

Comment 10

[Håkan Waara]

Attachment: Patch for the goodness.

Comment 11

[timeless]

I don't like 'always accept this certificate'

Comment 12

[Matthew T (active 1999-2002)]

Nor do I, now I think about it some more. (As opposed to ... Remember this 
certificate 50 % of the time?)


Try:

[ ] Remember this certificate permanently

The Cancel/Continue button order is wrong on Windows, that probably needs to be 
fixed before this can be checked in.

Comment 13

[Håkan Waara]

Attachment: New screenshot

Comment 14

[Håkan Waara]

Attachment: Patch for the screenshot, which incorporates all of mpt's comments

Comment 15

[Håkan Waara]

Got mpt's UI approval: <mpt> hwaara: That's gorgeous!

And now I need r= and sr=. I want this in for 0.9.3 btw.

Comment 16

[Håkan Waara]

Attachment: Better patch. Last patch was horked due to unknown forces.

Comment 17

[Joe Hewitt (gone)]

sr=hewitt once hwaara makes one change I suggested to him via AIM

Comment 18

[Sean Cotter]

I'd like to reword the text at the top of the warning as follows:

----
There is a problem with the certificate that identifies "[cert subject name]".
Do you want to continue?

The certificate was issued by a certificate authority that [name of browser]
does not recognize.
----

Reasoning:

- Mostly the rest of the UI uses just "certificate" rather than "security
certificates," which is a leftover from 4.x. 

- It may help to indicate that the certificate in question identifies the web
site (as opposed to--possibly--a client cert that identifies the user to the web
site). 

- "certificate authority" is lowercase most places, I think.

Help will need changes to match the new design. But it should be shorter as a
result, and hopefully fewer people will feel like they need it.

I can give r=cotter on the revised text (as shown above, assuming nobody else
has any objections), but don't trust me on the code.

Comment 19

[Håkan Waara]

Attachment: Final patch. Hewitt's and Sean's comments incorporated.

Comment 20

[Håkan Waara]

javi promised to do a final review and checkin.

thanks!

Comment 21

[Javier Delgadillo]

It seems that your patch doesn't set the key-bindings for return and ESC.  Why
aren't those set anymore? 

Comment 22

[Håkan Waara]

Attachment: fixed keys to work too.

Comment 23

[Javier Delgadillo]

r=javi

Will check in once tree opens.

Comment 24

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

a=dbaron on behalf of drivers for trunk checkin during 0.9.3 closure

Comment 25

[Javier Delgadillo]

Patch checked in.

Comment 26

[John Unruh]

Verified fixed.

Comment 27

[Aleksey Nogin]

There are two problems with this patch:

1) I am not sure whether it was this patch, or something else, but accepting
unknown certificates stopped working at all for me - both "Continue" and
"Cancel" buttons in the new dialog behave exactly the same for me - Mozilla is
not going to the site I want it to go. I tried it on several sites and it is
100% always reproducible, no matter whether I select "remember" or not.

2) Help button brings help window that explains the *old* dialog.
I am using Build ID 2001072923 from mozilla.org RH7 RPMs on RH 7.1

Comment 28

[Stephane Saux]

works for me on Linux commercial build 2001080106.

Comment 29

[Javier Delgadillo]

There is something very weird going on, because this is horked for me on my
daily build on Linux.  :(

Comment 30

[Aleksey Nogin]

I also see the same problem with "continue" not doing anything on another RedHat
7.1 machine running Build ID 2001072711 (from mozilla.org RPMs).

Also, I assume that WFM was about problem 1, what about problem 2 (outdated help
files)?

P.S. The last time I saw a problem with something working in commercial builds,
but not in RedHat 7 RPMs was when some variable was used uninitialized (I guess
the commercial build compilers initiazes them anyway). Can this be the case here?

Comment 31

[Aleksey Nogin]

Severity => major since currently it's impossible to access sites with unknows
CA on affected platforms.

Comment 32

[Stephane Saux]

*** Bug 93045 has been marked as a duplicate of this bug. ***

Comment 33

[Håkan Waara]

log a new bug please.  i'll fix it when i'm back from my vacation.

Comment 34

[Håkan Waara]

at least the ui's not horked any longer. ;)

fixed.

Comment 35

[Aleksey Nogin]

I have reported the problem of an outdated help file - bug 94104

I can no longer repproduce the problem of "continue" not working on BuildId
2001080600. If somebody still can, please log a new bug on that and add a note
to this bug.

Comment 36

[Stephen Walker]

*** Bug 94401 has been marked as a duplicate of this bug. ***

Comment 37

[ckritzer (gone)]

Marking VERIFIED FIXED on:
Win2k  2001-08-10-10-trunk Commercial
MacOSX 2001-08-10-05-trunk Commercial

Comment 38

[Stephane Saux]

*** Bug 97871 has been marked as a duplicate of this bug. ***

Comment 39

[bsharma]

Verified on
build: 2001-09-13-0.9.4
platform: Win NT

When attempting to load the site where CA is not recognized, the warning dialog
does show up correctly.

Comment 40

[Erich 'Ricky' Iseli]

Comment on attachment 43330 [details] [diff] [review]
Before (screenshot)

Since the mime type is wrong and a new attachment has been posted, this
attachment is obsolete.