914704 - Add WebIDL headers to install manifest

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Gregory Szorc [:gps]]

WebIDL files are now tracked in moz.build (bug 912197). This means we can now track the .h files via install manifests. As part of this, we could also generate the .h files directly into dist/include if we so desired.

Comment 1

[Gregory Szorc [:gps]]

Attachment: Part 1: Add WebIDL headers to dist/include install manifest

This reduces the number of files purged from dist/include by hundreds.

Comment 2

[Gregory Szorc [:gps]]

Attachment: Part 2: Generate WebIDL headers directly into dist/include

This patch doesn't actually work. Just throwing it up for posterity.

The reason it doesn't work is that the generated .cpp files expect the
.h files to be in the current directory because they reference
"FooBinding.h" instead of "mozilla/dom/FooBinding.h" because test-only
bindings aren't exported. We could probably have different code paths
for test-only bindings and generate non-test-only .h directly into
dist/include. But that's followup territory. And, it may never be high
enough on the priority list to warrant doing. So let's just leave this
bug as the first part.

Comment 3

[Gregory Szorc [:gps]]

Attachment: Add WebIDL headers to dist/include install manifest

Don't add test-only .h files to the manifest.

Comment 4

[Gregory Szorc [:gps]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/322e3797b68b

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/322e3797b68b