914857 - Remove progress popup notification on errors

Status: RESOLVED FIXED

(Firefox Graveyard :: Web Apps, defect)

Description

[Marco Castelluccio [:marco]]

Attachment: stop_progress_on_errors

We should remove the progress popup notification when the mozApps API fails to install an application.

Comment 1

[Marco Castelluccio [:marco]]

Attachment: Patch

Try run here: https://tbpl.mozilla.org/?tree=Try&rev=706c5dd4ccea

Comment 2

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 804906 [details] [diff] [review]
Patch

Review of attachment 804906 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/modules/webappsUI.jsm
@@ +21,5 @@
>                                     "@mozilla.org/childprocessmessagemanager;1",
>                                     "nsIMessageSender");
>  
>  this.webappsUI = {
> +  installations: {},

just add a comment here saying this is a list of promises for installations that are in progress.

We could also change the name of the variable to make it more clear, but it would probably get too big.  installsInProgress or something?  I guess if the comment is clear enough it's not necessary, but "installations" gives me the sense of "currently installed apps"

Comment 3

[Marco Castelluccio [:marco]]

Attachment: Patch

Thank you for the quick review!

Comment 4

[:Felipe Gomes (needinfo for replies!)]

https://hg.mozilla.org/integration/fx-team/rev/de540bd0137e

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/de540bd0137e