Closed
Bug 914937
Opened 11 years ago
Closed 11 years ago
Remove nsFlexContainerFrame's GetSkipSides specialization, now that it can inherit one from nsSplittableFrame
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla26
People
(Reporter: dholbert, Assigned: dholbert)
References
Details
Attachments
(1 file)
|
2.05 KB,
patch
|
MatsPalmgren_bugz
:
review+
|
Details | Diff | Splinter Review |
I added nsFlexContainerFrame::GetSkipSides in bug 870555, basically copypasted from nsBlockFrame's specialization. Since then, bug 743402 *removed* nsBlockFrame's specialization[1], and promoted it (with improvements) to live on nsSplittableFrame, which nsFlexContainerFrame derives from. So, we can remove nsFlexContainerFrame::GetSkipSides() now, and just use the inherited version. [1] https://hg.mozilla.org/mozilla-central/rev/352501d3f390#l1.12
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #802727 -
Flags: review?(matspal)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 802727 [details] [diff] [review] fix r=mats
Attachment #802727 -
Flags: review?(matspal) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/02a38c597287
Flags: in-testsuite-
|
||
Comment 4•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/02a38c597287
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in
before you can comment on or make changes to this bug.
Description
•