916236 - Improvements to sketchfab plugin

Status: RESOLVED FIXED

(Webmaker Graveyard :: Popcorn Maker, defect)

Description

[Matthew Schranz [:mjschranz]]

1) It's editor is missing a label for the id input.
2) It's id input should be capable of parsing sketchfab URLs e.g: http://sketchfab.com/show/b7LzIm8JrnPw4GBDOMBNGYc39qM
3) We should move it down to the bottom of the plugin list. More of a preference than actual problem.

Comment 1

[Bobby Richter [:secretrobotron]]

#2 is a bug in the regex in popcorn.sketchfab.js.

`src = options.src.match( /((show|skfb\.ly)\/)?([A-Za-z0-9]{9,27})/ );`

Notice {9,27} tries to capture the model id, but that "sketchfab" is also 9 characters long :/.

Comment 2

[Matthew Schranz [:mjschranz]]

Ah, well that needs to be fixed and it needs to be obvious that this already was a present feature :P

Comment 3

[ben]

I agree with :mjschranz. I would put it last in the list order of events.

Moreover, I think we should call the event "3D Model"

Suggested language for UI...

Add a label above the URL field: "Sketchfab.com URL"

Explanatory text below it: "You can include any 3D model from Sketchfab.com in your project. Your browser must support WebGL."

Comment 5

[Matthew Schranz [:mjschranz]]

As said in the duplicate bug and emails, I've set this plugin to be hidden from our events list until the UI improvements are made.

https://github.com/mozilla/popcorn.webmaker.org/commit/3c5c364dbe8efa157e7b2fe03c5b40e3f131d59e

I haven't pushed this to our staging server, but if production pushes are to be made before this bug is resolved then we will be getting that commit up on prod as well.

Comment 6

[Matthew Schranz [:mjschranz]]

Attachment: https://github.com/mozilla/popcorn.webmaker.org/pull/207

Just the basics.

Comment 7

[Bobby Richter [:secretrobotron]]

Attachment: https://github.com/mjschranz/popcorn.webmaker.org/pull/5

- Makes Sketchfab its own editor (doesn't use default).
- Adds blurb & video about Sketchfab to help understand the plugin :).
- Uses some error propagation to tell the user when they've entered a bad url.

Comment 8

[Scott [:thecount] Downe]

Comment on attachment 806015 [details] [review]
https://github.com/mjschranz/popcorn.webmaker.org/pull/5

Some easy quick improvements.

Add:


  EditorHelper.selectable( trackEvent, container );

To the editor helper. I noticed there is no select state on the stage container. Usually we get a green border/box shadow when selected. Same with when in edit mode, and hover. Sketchfab only seems to get the hover states. I think your css is overriding the select css? maybe?

Also, why not enable the north west resize handle.

Otherwise r+

Comment 9

[Scott [:thecount] Downe]

Actually, now that I'm thinking about borders, I wonder if sketchfab should have one at all?

If I make something with a transparent background, I probably don't want a border either. That way I can overlay it over other images or video in more creative ways.

Comment 10

[Bobby Richter [:secretrobotron]]

Attachment: https://github.com/mozilla/popcorn.webmaker.org/pull/208

Merges with Matt's work, and includes fixes for Scott.

Comment 11

[Bobby Richter [:secretrobotron]]

Matt, can you land this?

Comment 12

[[github robot]]

Commit pushed to master at https://github.com/mozilla/popcorn.webmaker.org

https://github.com/mozilla/popcorn.webmaker.org/commit/dd27d37d0c3eb3b2adc698e6c3f25c9a1b9e0879
Bug 916236 - Sketchfab plugin improvements

[t916236] fix minor usability issues with sketchfab plugin; reenable it's ability to be seen
[t916236] custom sketchfab for a blurb about Sketchfab.com
[t916236] sketchfab background fix & URL error
[t916236] editor helper fixes

Comment 13

[Matthew Schranz [:mjschranz]]

Needs verification.