916257 - modernize ipdlsrcs.mk writing

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Nathan Froyd [:froydnj]]

I started refactoring ipdlsrcs.mk writing so that I could build ipc/ipdl in
unified mode per bug 907789.  I ran into some problems, which need to be
solved elsewhere, b ut I thought I would at least throw the patches up for
review now, since they're all finished.

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: part 1 - convert ipdlsrcs.mk writing to use mozbuild.makeutil

We have better ways to do things nowadays.  Trivial.

Comment 2

[Nathan Froyd [:froydnj]]

Attachment: part 2 - write CPPSRCS from each ipdl file in one go

This patch is probably misnamed; it's mostly here to separate the logic for
determining what files we're generating from a single ipdl file from the logic
for actually writing the necessary definitions.

Comment 3

[Nathan Froyd [:froydnj]]

Attachment: part 3 - write ALL_IPDLSRCS and CPPSRCS in one go

Maybe not strictly necessary, but if pymake is happier with a single statement
rather than a bunch of variable appends, a small efficiency improvement.

Comment 4

[Gregory Szorc [:gps]]

Comment on attachment 804629 [details] [diff] [review]
part 3 - write ALL_IPDLSRCS and CPPSRCS in one go

Review of attachment 804629 [details] [diff] [review]:
-----------------------------------------------------------------

Huzzah!

Comment 5

[Nathan Froyd [:froydnj]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/046a32ac9131
https://hg.mozilla.org/integration/mozilla-inbound/rev/8dfc5c8b3c8b
https://hg.mozilla.org/integration/mozilla-inbound/rev/60933bd9e217

Comment 6

[Matt Brubeck (:mbrubeck)]

Sorry, I backed this out on inbound:
https://hg.mozilla.org/integration/mozilla-inbound/rev/dbb0d3946a92

because of this build error:
NameError: global name 'mozmakeutil' is not defined
https://tbpl.mozilla.org/php/getParsedLog.php?id=27853917&tree=Mozilla-Inbound

Comment 7

[Nathan Froyd [:froydnj]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a8da12b9e73f
https://hg.mozilla.org/integration/mozilla-inbound/rev/e9a59bc50ffb
https://hg.mozilla.org/integration/mozilla-inbound/rev/e068176c4814

Actually |import|'d all the things I was supposed to this time, rather than relying on previous patches in my queue to provide them.

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/853f3f44cb3b for bustage like this: https://tbpl.mozilla.org/php/getParsedLog.php?id=27863229&tree=Mozilla-Inbound

Comment 9

[Nathan Froyd [:froydnj]]

Attachment: part 2 - separate out files-from-this-ipdl logic from writing CPPSRCS

Ah, the tests, the tests.  Must fix the tests.

I think the blank lines technically from from the mozbuild.makeutil conversion,
but I am being lazy and not splitting the test changes up amongst all three
patches...

Comment 10

[Nathan Froyd [:froydnj]]

Attachment: part 3 - write ALL_IPDLSRCS and CPPSRCS in one go

More test changes.  Wasn't quite sure what to do about the overly long lines; please
yell if the chosen path is not acceptable.

Comment 11

[Gregory Szorc [:gps]]

Comment on attachment 808596 [details] [diff] [review]
part 3 - write ALL_IPDLSRCS and CPPSRCS in one go

Review of attachment 808596 [details] [diff] [review]:
-----------------------------------------------------------------

I am slightly scared by the frequency you use itertools. The force is strong with you.

Comment 12

[Nathan Froyd [:froydnj]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/deade1888427
https://hg.mozilla.org/integration/mozilla-inbound/rev/34649bc0a5e2
https://hg.mozilla.org/integration/mozilla-inbound/rev/7f6b24ef59c2

Comment 13

[Nathan Froyd [:froydnj]]

(In reply to Gregory Szorc [:gps] from comment #11)
> I am slightly scared by the frequency you use itertools. The force is strong
> with you.

\o/

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/deade1888427
https://hg.mozilla.org/mozilla-central/rev/34649bc0a5e2
https://hg.mozilla.org/mozilla-central/rev/7f6b24ef59c2