916282 - Lock and camera buttons are not available with explore by touch in screen reader

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System::Lockscreen, defect)

Description

[Eitan Isaacson [:eeejay]]

This has to do with the fact that #lockscreen-icon-container has pointer-events set to none.

Comment 1

[Yura Zenevich [:yzen] (please use "needinfo")]

Attachment: Github pull request.

Comment 2

[Eitan Isaacson [:eeejay]]

Comment on attachment 814283 [details] [diff] [review]
Github pull request.

This looks good to me. Forwarding review to module owner.

Comment 3

[Eitan Isaacson [:eeejay]]

Comment on attachment 814283 [details] [diff] [review]
Github pull request.

Reverting my feedback after testing. Looks like the areas could be directly clicked now when not in screen reader mode. That should not happen.

Comment 4

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 814283 [details] [diff] [review]
Github pull request.

Removing r? because of f-. Please ask :snowmantw ([e-mail]) for review afterward.

We will probably need to figure out a way to test screen reader before r+'ing this bug (instead of asking eitan to verify it).

Comment 5

[Yura Zenevich [:yzen] (please use "needinfo")]

Attachment: Github pull request v2.

Comment 6

[Greg Weng [:snowmantw][:gweng][:λ]]

On the simulator the only difference I can see is the icon now can't be clicked to lighten when I turn off the Screen Reader (of course it's the result in UX, not what we really concern). If I enable it and use the navigation tools to move on the icon and click on it, no matter which mode I was in, the behavior seems no difference.

So maybe as Tim said, it's better to wait a way to test screen reader, and I really need some feedback.

Comment 7

[Eitan Isaacson [:eeejay]]

(In reply to Greg Weng [:snowmantw] from comment #6)
> On the simulator the only difference I can see is the icon now can't be
> clicked to lighten when I turn off the Screen Reader (of course it's the
> result in UX, not what we really concern). If I enable it and use the
> navigation tools to move on the icon and click on it, no matter which mode I
> was in, the behavior seems no difference.

Besides the linear navigation in the screen reader, there is also a feature called "explore by touch" that allows the user to highlight an object by putting their finger over it. That doesn't currently work for the lockscreen buttons in gaia master.

> 
> So maybe as Tim said, it's better to wait a way to test screen reader, and I
> really need some feedback.

It sounds like you were able to use the screen reader, no? If not there are two option. The last two sections of this post explain how:
http://blog.monotonous.org/2013/10/09/an-introduction-to-making-firefox-os-apps-accessible/

Comment 8

[Yura Zenevich [:yzen] (please use "needinfo")]

I updated the pull request and the icons now lighten on click as before.

Comment 9

[Greg Weng [:snowmantw][:gweng][:λ]]

Comment on attachment 815728 [details] [diff] [review]
Github pull request v2.

Thanks Eitan's guide. I've tested the patch and it works fine, so I would grant it. However, may Yura can push it to GitHub again to pass the test before merge it. It's currently broken due to a irrelevant error, and maybe rerunning the test can solve it.

Comment 10

[Yura Zenevich [:yzen] (please use "needinfo")]

Pushed again as requested.

Comment 11

[Greg Weng [:snowmantw][:gweng][:λ]]

The alarm failed as I heard in these days...
Nevertheless, Yura, please merge it, thanks.

Comment 12

[Eitan Isaacson [:eeejay]]

https://github.com/mozilla-b2g/gaia/commit/0fea8a6492c5795ec6e2799c0b65cb61fc86e3b4

Comment 13

[Marco Zehe (:MarcoZ)]

Verified in latest Gaia Master.