916685 - (CVE-2013-5601) ASAN use-after free in GC allocation in nsEventListenerManager::SetEventHandler

Status: RESOLVED FIXED

(Core :: DOM: Events, defect)

Description

[Nils]

Attachment: crash.html

The attached testcase crashes the nightly ASAN build.  It require domFuzzLite3. ASAN output attached in stack.txt.

Comment 1

[Nils]

Attachment: stack.txt (ASAN output)

Comment 2

[David Bolter [:davidb] (NeedInfo me for attention)]

Sounds bad.

Comment 3

[Andrew McCreight [:mccr8]]

I'll take a look at this this week.

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Attachment: patch

Bring back the pre-EventHandler behavior

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

http://mxr.mozilla.org/comm-esr17/source/mozilla/content/events/src/nsEventListenerManager.cpp?rev=618ffd249ae7&mark=778-780#777 has the old behavior.

Comment 6

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 810312 [details] [diff] [review]
patch

r=me, but how are we getting a null boundHandler here?  Is the JSObjectFromInterface failing?  Seems like the only way that could happen...

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

We end up to BindCompiledEventHandler when mIsInitialized is false. nsJSContext hasn't been
unlinked yet, so we're dealing with a context which initialization somehow failed.

Comment 8

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 810312 [details] [diff] [review]
patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): I think Bug 807226
User impact if declined: crashes, possibly exploitable
Testing completed (on m-c, etc.):  NA
Risk to taking this patch (and alternatives if risky): Should be safe. Setting a member variable explicitly to null 
String or IDL/UUID changes made by this patch: NA

Comment 9

[Al Billings [:abillings - ex-MoCo]]

Comment on attachment 810312 [details] [diff] [review]
patch

sec-approval+ for trunk. As you say, this looks pretty safe so I'm giving it branch approval elsewhere for after it makes it into trunk and things are green.

Is B2G affected?

Comment 10

[Olli Pettay [:smaug][[e-mail]]]

I have no idea which branch b2g uses these days, so I don't know whether it is affected.
b2g-18 shouldn't be.

Comment 11

[Olli Pettay [:smaug][[e-mail]]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/802e8457aef7

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/802e8457aef7

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/a684bd944d90
https://hg.mozilla.org/releases/mozilla-beta/rev/e57b395d27d3
https://hg.mozilla.org/releases/mozilla-esr24/rev/79e83c7512d5

Comment 14

[Matt Wobensmith [:mwobensmith][:matt:]]

Hi Nils - I'm not able to recreate the crash with an ASan build from 2013-09-16 and the domFuzz extension.

Would you mind trying this on a recent build to verify that we've indeed fixed it? Any branch. Thank you.

Comment 15

[Nils]

Hi Matt, I can confirm that this testcase doesn't crash anymore in the latest ASAN build. I will keep a look out for similar crashes in my next fuzzing run.

Comment 16

[Matt Wobensmith [:mwobensmith][:matt:]]

Thank you, Nils.