Closed Bug 916833 Opened 11 years ago Closed 10 years ago

Avatar not centered in mobile profile view

Categories

(Participation Infrastructure :: Phonebook, defect)

2014-07.1
All
Android
defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: giorgos, Assigned: wbowling)

Details

(Whiteboard: [kb=1426235] )

Attachments

(1 file)

On android / firefox the avatar is not centered in profile view.
Summary: Avatar not centered in profile view → Avatar not centered in mobile profile view
Attachment shows the avatar is not centered. If it was centered, the highest part of the avatar would be under the "n" of "Mozillian Profile", but instead it's under the "r". So it's about 10% or 15% more right than it should be.
Assignee: nobody → scott.leea
I played around with the CSS and it looks more centered now. Let me know what you think.

https://github.com/mozilla/mozillians/pull/972
There are a lot of breakpoints in the CSS. The solution to centering something in CSS is to give it automatic side margins. If you keep adjusting a left-side offset as a percentage of the container's width when the size of the image is not defined also by a percentage then it will always be off-center.

I'm seeing if I can rewrite it.
Assignee: scott.leea → wbowling
Assigned to wbowling since he has a fix.
Status: NEW → ASSIGNED
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Version: other → next
Whiteboard: [kb=1426235]
QA verified on stage - profile image appears centered
- Android 4.4.4 Firefox for Android & Chrome
- iOS latest [iPod touch] Safari
- Firefox OS latest
Status: RESOLVED → VERIFIED
Version: next → 2014-06.6
Version: 2014-06.6 → 2014-07.1
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: