Closed
Bug 917238
Opened 11 years ago
Closed 11 years ago
[Settings] Network types is always empty
Categories
(Firefox OS Graveyard :: Gaia::Settings, defect)
Tracking
(blocking-b2g:koi+, b2g-v1.2 verified)
People
(Reporter: arthurcc, Assigned: arthurcc)
Details
Attachments
(1 file)
The issue was regressed by bug 914152. STR: 1. Launch the settings AP 2. Cellular & Data -> Network operator 3. Check network type drop down list Actual result: It is empty Expected result: It should have network types as what listed in network.json
Assignee | ||
Comment 1•11 years ago
|
||
Evelyn, when I moved the common logic to util.js, I deleted the network type related logic by mistake. Could you help review this change? Thanks!
Attachment #805922 -
Flags: review?(ehung)
Assignee | ||
Updated•11 years ago
|
blocking-b2g: --- → koi?
Comment 2•11 years ago
|
||
Comment on attachment 805922 [details] Link to https://github.com/mozilla-b2g/gaia/pull/12264 r- because I think we can simply rewrite `getSupportedNetworkCategories` in util.js to avoid querying twice.
Attachment #805922 -
Flags: review?(ehung) → review-
Assignee | ||
Comment 3•11 years ago
|
||
Comment on attachment 805922 [details] Link to https://github.com/mozilla-b2g/gaia/pull/12264 Comment addressed. Could you help review it again? Thanks!
Attachment #805922 -
Flags: review- → review?(ehung)
Updated•11 years ago
|
blocking-b2g: koi? → koi+
Comment 4•11 years ago
|
||
Comment on attachment 805922 [details] Link to https://github.com/mozilla-b2g/gaia/pull/12264 r=me, thanks!
Attachment #805922 -
Flags: review?(ehung) → review+
Assignee | ||
Comment 5•11 years ago
|
||
Thanks! master: https://github.com/mozilla-b2g/gaia/commit/4d28cf400b523e26d22b3a5ebe15a75764e48390
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 7•11 years ago
|
||
v1.2: 1e9470b9b6df630eddf1c4c8b25b3170ee786b0e
status-b2g-v1.2:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•