917286 - Outdated hyperlinks on webmaker.org/tools - replace with /starter-makes

Status: RESOLVED FIXED

(Webmaker Graveyard :: webmaker.org, defect)

Description

[Jacob [:Jacob]]

This page - https://webmaker.org/tools has outdated hyperlinks for the two buttons that say "remix a make" under Popcorn Maker and Thimble.

The current buttons point to - https://webmaker.org/en-US/search?type=tags&q=webmaker%3Atemplate

But need to point to - https://webmaker.org/starter-makes

^ however, we don't have any official starter makes for popcorn yet. Maybe we should point this to an easy popcorn project to remix?

Either way, it's better than the current tag search for webmaker:template

Also, another note, I've been noticing that some of our hyperlinks have /EN-us baked in them because they were copy/pasted in from the URL bar.

That's bad localization practice since it forces non-English site users to load an English version of the site (I believe).

We need to be on the lookout for that elsewhere (there's one on the current about page. See bug #915770) and switch it out if we notice it.

Comment 1

[Dale Karp (:daleee)]

Attachment: 'Code' Review

https://github.com/mozilla/webmaker.org/pull/384/

Comment 2

[[github robot]]

Commits pushed to master at https://github.com/mozilla/webmaker.org

https://github.com/mozilla/webmaker.org/commit/ac51fdc4f9685f2ac93bbb3c36d5e04becb5e251
[bug 917286] Outdated links on /tools

https://github.com/mozilla/webmaker.org/commit/380ee0d654c19c07ec23bf952c39c645ae36c642
Merge pull request #384 from daleee/917286_outdated-links-on-tools

[bug 917286] Outdated links on /tools