917323 - gonk/nsWindow doesn't implement nsIWidget::NotifyIME()

Status: RESOLVED INVALID

(Core Graveyard :: Widget: Gonk, defect)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

gonk/nsWindow doesn't implement nsIWidget::NotifyIME().

NotifyIME() notifies IME of something events or requests:

437 // NotificationToIME is shared by nsIMEStateManager and TextComposition.
438 enum NotificationToIME {
439   // XXX We should replace NOTIFY_IME_OF_CURSOR_POS_CHANGED with
440   //     NOTIFY_IME_OF_SELECTION_CHANGE later.
441   NOTIFY_IME_OF_CURSOR_POS_CHANGED,
442   // An editable content is getting focus
443   NOTIFY_IME_OF_FOCUS,
444   // An editable content is losing focus
445   NOTIFY_IME_OF_BLUR,
446   // Selection in the focused editable content is changed
447   NOTIFY_IME_OF_SELECTION_CHANGE,
448   REQUEST_TO_COMMIT_COMPOSITION,
449   REQUEST_TO_CANCEL_COMPOSITION
450 };

At least REQUEST_TO_* should be implemented for consistency behavior between platforms.

Currently, on B2G, composition is synthesized as for testing. Therefore, they are emulated by nsIMEStateManager.
http://mxr.mozilla.org/mozilla-central/source/content/events/src/nsIMEStateManager.cpp?rev=545c76a2bf6f#592

The method would be called after bug 917322 would be fixed and modify the CompositionManager implementation for it.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Looks like that dom/inputmethod/forms.js has two jobs. One is handling some requests from IME. The other is notifying IME of content's change.

The latter looks bad copy of IMEStateManager. Duplicating the implementation causes incompatibility with Firefox OS and Firefox for Desktop and Android.

I think that not only NotifyIME(), IMEStateManager should send notifications which is wanted by forms.js and forms.js should only handle that for the latter job. And it should stop handling a lot of events and using nsIEditorObserver and MutationObserver. If so, forms.js must be much simpler and share every behavior between other platforms.

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Now, we don't need to fix this bug since nsITextProcessorCallback allows to implement this in JS. (bug 917322)