Closed Bug 917732 Opened 11 years ago Closed 11 years ago

[Keyboard] Candidate panel displays wrong data when clicking candidate-panel-toggle-button and space key at the same time

Categories

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(blocking-b2g:koi+, b2g-v1.2 fixed)

RESOLVED FIXED
1.2 C4(Nov8)
blocking-b2g koi+
Tracking Status
b2g-v1.2 --- fixed

People

(Reporter: lchang, Assigned: lchang)

Details

Attachments

(2 files)

Attached image Screenshot
Please refer to attachment.

STR:

1. find a text field to open keyboard app
2. switch to pinyin layout
3. click 'z', it will show some candidates
4. press down candidate-panel-toggle-button
5. press down space key
6. release candidate-panel-toggle-button
7. release space key
Attached file Pull Request
This patch tried to prevent triggering the "endPress" event when the target button is invisible.
Attachment #806567 - Flags: review?(rlu)
Blocking, functional issue.
blocking-b2g: koi? → koi+
Target Milestone: --- → 1.2 C4(Nov8)
Comment on attachment 806567 [details]
Pull Request

r=me.

Thanks for the work.
Attachment #806567 - Flags: review?(rlu) → review+
travis passed:
https://travis-ci.org/mozilla-b2g/gaia/builds/13031617

merged in gaia master:
https://github.com/mozilla-b2g/gaia/commit/c59be1ad4a0bc005ff648eae59c441cb03771fbf

Rudy, Thanks.
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Uplifted c59be1ad4a0bc005ff648eae59c441cb03771fbf to:
v1.2: 35568e976bf44c7a73062558cc0f838c1fa97478
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: