917878 - "patches submitted" and "patches reviewed" on the user profile don't take github pull requests into consideration

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: Extensions, defect)

Description

[:glob ✱]

some teams use github to track their development, but use bugzilla to track their reviews.  their process involves attaching a github pr url, and requesting a review on that.

because these attachments aren't tagged as patches, they are not counted by the user profile :(


one way of fixing this is to add a new column to attachments - is_github (or similar) and automatically set that to true when the attachment is created.  the user profile can then search for (ispatch = 1 OR is_github = 1).  that would also help the redirect when viewing (bug 916906).

Comment 2

[:glob ✱]

we need to look for a content-type of text/x-github-pull-request

Comment 3

[David Lawrence [:dkl]]

Attachment: 917878_1.patch

Comment 4

[:glob ✱]

Comment on attachment 8372637 [details] [diff] [review]
917878_1.patch

nice, r=glob

once this has been pushed we'll have to run the following SQL to trigger a recalculation of existing statistics:

UPDATE profiles SET last_statistics_ts = NULL WHERE userid IN (SELECT submitter_id FROM attachments WHERE mimetype = 'text/x-github-pull-request');

Comment 5

[David Lawrence [:dkl]]

Committing to: bzr+ssh://[e-mail]/bmo/4.2
modified extensions/UserProfile/lib/Util.pm
Committed revision 9225. 

glob, please have ashish (or whomever does the push) run the SQL then afterwards.

dkl

Comment 6

[Asa Dotzler [:asa]]

Any chance you all can also capture this pull-request.html (text/html) pattern? I see it a lot in Firefox OS, like https://bugzilla.mozilla.org/show_bug.cgi?id=922609

Comment 7

[:glob ✱]

(In reply to Asa Dotzler [:asa] from comment #6)
> Any chance you all can also capture this pull-request.html (text/html)
> pattern? I see it a lot in Firefox OS, like
> https://bugzilla.mozilla.org/show_bug.cgi?id=922609

as that request is very different from this bug, i've filed as bug 970195.

Comment 8

[Ashish Vijayaram [:ashish]]

(In reply to David Lawrence [:dkl] from comment #5)
> Committing to: bzr+ssh://[e-mail]/bmo/4.2
> modified extensions/UserProfile/lib/Util.pm
> Committed revision 9225. 
> 
> glob, please have ashish (or whomever does the push) run the SQL then
> afterwards.
> 
> dkl

SQL ran successfully on the master:

> mysql> UPDATE profiles SET last_statistics_ts = NULL WHERE userid IN (SELECT submitter_id FROM attachments WHERE mimetype = 'text/x-github-pull-request');
> Query OK, 307 rows affected, 1 warning (6.89 sec)
> Rows matched: 333  Changed: 307  Warnings: 1