91790 - Malloc of 0 - nsMsgDBView.cpp

Status: VERIFIED FIXED

(MailNews Core :: Backend, defect)

Description

[Mike Kaply [:mkaply]]

This code:

http://lxr.mozilla.org/seamonkey/source/mailnews/base/src/nsMsgDBView.
cpp#2206

Is bad.

for empty folders, arraySize is 0, so not only does a malloc of 0 
happen, but lots of unnecessary code is traversed.

I am not sure what the right thing is to do here - possibly just 
return NS_OK if arraySize is 0?

Comment 1

[Mike Kaply [:mkaply]]

Attachment: Three View cases - return if there are no items to sort

Comment 2

[Mike Kaply [:mkaply]]

I've attached a fix for this.

On OS/2 we were asserting all over the place on the 0 mallocs.

This fixes all of our problems, and gives the same behavior as before.

To test, go to an empty folder and try all the different sorts, as 
well as threaded view. everything should work as before.

Comment 3

[Mike Kaply [:mkaply]]

Without this fix, mail is unstable on OS/2.

The 0 mallocs causes us to get "Unknown error" popups and random 
crashes on release builds.

I need this fix.

Comment 4

[Scott MacGregor]

Mike, do you want me to check this patch in or do you want to?

sr=mscott either way. 

although I prefer the if (!foo) notation insead of if (foo == 0). Either way
though. 

Comment 5

[Mike Kaply [:mkaply]]

I'll check it in, no prob, and I'll fix the syntax.

Do you definitely agree that this is the right thing to do (return NS_OK if 
there is nothing to sort)

Comment 6

[Scott MacGregor]

yup, I agree that it's the right thing to do. 

Comment 7

[Mike Kaply [:mkaply]]

Fix checked in

Comment 8

[[e-mail] (gone - use [e-mail] instead)]

verified fixed via code inspection (using LXR).