918160 - Set.js contains lots of .call()

Status: RESOLVED DUPLICATE of bug 987243

(Core :: JavaScript Engine, defect)

Description

[Jason Orendorff [:jorendorff]]

I think all these need to be replaced with callFunction.

Comment 1

[Jason Orendorff [:jorendorff]]

Lest I get pegged with the review I'm taking this.

Comment 2

[Jason Orendorff [:jorendorff]]

Attachment: v1

This patch changes the error message when you do something silly like:

js> var obj = new Date;
js> obj.forEach = Map.prototype.forEach;
js> obj.forEach(_ => _)
typein:3:0 TypeError: entries method called on incompatible Date

It used to say "unknown type object".

Comment 3

[Till Schneidereit [:till]]

Comment on attachment 807714 [details] [diff] [review]
v1

Review of attachment 807714 [details] [diff] [review]:
-----------------------------------------------------------------

There's nothing not to love about this.