Closed
Bug 918240
Opened 11 years ago
Closed 11 years ago
Can possibly remove "Restart required - restart now?" from chrome and remote debugging pref
Categories
(DevTools :: Debugger, defect, P3)
DevTools
Debugger
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 27
People
(Reporter: Gijs, Assigned: past)
References
Details
Attachments
(1 file)
6.24 KB,
patch
|
jwalker
:
review+
miker
:
review+
|
Details | Diff | Splinter Review |
After bug 917706, I *think* restarts are no longer required to toggle chrome/remote debugging - but I'm not familiar with remote debugging besides browser debugging, so I could be wrong... Looking at: http://mxr.mozilla.org/mozilla-central/search?string=debugger.remote-enabled&find=&findi=&filter=^[^\0]*%24&hitlimit=&tree=mozilla-central http://mxr.mozilla.org/mozilla-central/search?string=debugger.chrome-enabled&find=&findi=&filter=^[^\0]*%24&hitlimit=&tree=mozilla-central I'm 99% sure this will Just Work without a restart. The debugger server's openListener checks the live pref, and metro has a pref observer for running the server... so it should be OK? Panos, does that sound accurate?
Flags: needinfo?(past)
Assignee | ||
Comment 1•11 years ago
|
||
Yes, we should just remove the notification from the panel.
Flags: needinfo?(past)
Assignee | ||
Comment 2•11 years ago
|
||
This should do it, although I haven't tested it yet. Laptop is busy building other patches.
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → past
Status: NEW → ASSIGNED
Assignee | ||
Updated•11 years ago
|
Priority: -- → P3
Reporter | ||
Comment 3•11 years ago
|
||
(In reply to Panos Astithas [:past] from comment #2) > Created attachment 807740 [details] [diff] [review] > Remove mentions of restarting in the options panel when toggling the remote > and chrome debugging prefs > > This should do it, although I haven't tested it yet. Laptop is busy building > other patches. I checked quickly - yes, this works. Thanks! :-)
Assignee | ||
Comment 4•11 years ago
|
||
Comment on attachment 807740 [details] [diff] [review] Remove mentions of restarting in the options panel when toggling the remote and chrome debugging prefs Yep, works fine and all tests pass.
Attachment #807740 -
Flags: review?(jwalker)
Comment 5•11 years ago
|
||
Comment on attachment 807740 [details] [diff] [review] Remove mentions of restarting in the options panel when toggling the remote and chrome debugging prefs Review of attachment 807740 [details] [diff] [review]: ----------------------------------------------------------------- Looks good to me, but I think it might be worth asking Mike to take a look - he wrote the original.
Attachment #807740 -
Flags: review?(jwalker) → review+
Assignee | ||
Comment 6•11 years ago
|
||
Comment on attachment 807740 [details] [diff] [review] Remove mentions of restarting in the options panel when toggling the remote and chrome debugging prefs Review of attachment 807740 [details] [diff] [review]: ----------------------------------------------------------------- I didn't know Mike wrote this code! Mike, does this change look OK?
Attachment #807740 -
Flags: review?(mratcliffe)
Comment 7•11 years ago
|
||
Comment on attachment 807740 [details] [diff] [review] Remove mentions of restarting in the options panel when toggling the remote and chrome debugging prefs Review of attachment 807740 [details] [diff] [review]: ----------------------------------------------------------------- Yup, looks good to me.
Attachment #807740 -
Flags: review?(mratcliffe) → review+
Assignee | ||
Comment 8•11 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/efab2edc6969
Whiteboard: [fixed-in-fx-team]
Comment 9•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/efab2edc6969
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 27
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•