918320 - [B2G] Add bg, bn-BD, it, mk, zh-CN to v1.2 builds

Status: VERIFIED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Delphine Lebédel [:delphine - Use needinfo]]

According to the bug tracking all required languages for v1.2, Italian and Bulgarian have been requested: see Bug 905292

However, I have noticed that Italian and Bulgarian do not appear on our internal builds. Please add both to languages_dev.json

Comment 1

[Delphine Lebédel [:delphine - Use needinfo]]

Updating bug. As per Bug 905292, Simplified Chinese has also been requested.
Please also add zh-CN to our v1.2 builds.

(Italian: it
Bulgarian: bg)

Comment 2

[Axel Hecht [:Pike]]

we'll need repos and mirroring for zh-CN, so we shouldn't jump on that yet. Filed bug 918367.

Comment 3

[Delphine Lebédel [:delphine - Use needinfo]]

Macedonian (mk) also missing

Comment 4

[Preeti Raghunath(:Preeti)]

Pike,

When will the mirroring complete?

Comment 5

[Axel Hecht [:Pike]]

The repos and mirrors were created in bug 918367.

The locales are about 88k each in terms of profile size. I think that should be good to take. That's just the l10n, not keyboards etc.

Comment 6

[bhavana bajaj [:bajaj]]

Pike what are the next steps here given 918367 is resolved.

Comment 7

[Axel Hecht [:Pike]]

I guess that it'd be helpful to have bug 924575 (v1.1 branching for l10n) out of the way, but the next steps are changing the languages_dev.json on both master and v1.2 branch, and languages_all.json on v1.2.

Comment 8

[bhavana bajaj [:bajaj]]

(In reply to Axel Hecht [:Pike] from comment #7)
> I guess that it'd be helpful to have bug 924575 (v1.1 branching for l10n)
> out of the way,

recently approved. landing away. 
> but the next steps are changing the languages_dev.json on
> both master and v1.2 branch, and languages_all.json on v1.2.

Comment 9

[Aki Sasaki (not active)]

https://github.com/mozilla-b2g/gaia/pull/12765
r?

Comment 10

[John O'Duinn [:joduinn] (please use "needinfo?" flag)]

(In reply to Axel Hecht [:Pike] from comment #7)
> I guess that it'd be helpful to have bug 924575 (v1.1 branching for l10n)
> out of the way, but the next steps are changing the languages_dev.json on
> both master and v1.2 branch, and languages_all.json on v1.2.

per b2g meeting w/clee just now, explicitly Italian is *not* needed on v1.1HD. That lines up with what we have here, with Italian on v1.1 and coming soon to v1.2 and master. I'm noting explicitly to avoid possible future concern about v1.1HD.

Comment 11

[Hal Wine [:hwine] use NI!]

(In reply to delphine from comment #3)
> Macedonian (mk) also missing

I don't believe a repository creation request was ever made for Macedonian, since comment 3 was made after bug 918367 was resolved.

Comment 12

[John O'Duinn [:joduinn] (please use "needinfo?" flag)]

axel: 

per clee, whenever we land a new locale in a given branch, we need to enable that locale on all newer branches (in this specific case, adding a locale to v1.2 means also adding it to v1.3/master). This helps with updates, amongst other things. I dont know if thats written down as explicit written policy someplace, but its been done in the past - bug#838516 is one example.

Given that, I'd initially thought we'd just morph this bug#918320 to also including enabling these locales on master. After all, thats what happened in bug#838516. However, after bug#918316#c5, if you prefer us to file separate bug to track enabling these-same-locales-on-master, let us know and we'll do that.

Comment 13

[Preeti Raghunath(:Preeti)]

Is this a meta bug? If not, it should be koi+

Comment 14

[Jason Smith [:jsmith]]

Leaving this in the koi? queue until we figure out if this is a meta bug or not.

Comment 15

[Axel Hecht [:Pike]]

mk repos are up, please land the PR for the 1.2 locales. All the other stuff in this bug is really just confusing me.

Comment 16

[Aki Sasaki (not active)]

Landed.

Comment 17

[Jason Smith [:jsmith]]

Sounds like we can close this then. Closing this out.

Also marking koi+ as this isn't a tracker bug per Pike's comments - it's required build changes for the 1.2 locales.

Comment 18

[Delphine Lebédel [:delphine - Use needinfo]]

Verified on Buri device, using today's latest v1.2 Com RIl
Marking as verified fixed

Comment 19

[Jason Smith [:jsmith]]

I'm assuming you didn't mean to flip the affected flag & blocking flag.

Comment 20

[Delphine Lebédel [:delphine - Use needinfo]]

No I didn't. It's really weird because I touched absolutely nothing and just changing the bug to resolved fixed did that. Was wondering if that was normal...(and apparently it's not)

Comment 21

[Ryan VanderMeulen [:RyanVM]]

(In reply to Aki Sasaki [:aki] from comment #16)
> Landed.

For posterity:
https://github.com/mozilla-b2g/gaia/commit/dbcc171eae6b4d9d168a48291d5ea54c7580561a