918337 - Adding a new generated jni method doesn't provide good error logging

Status: RESOLVED WORKSFORME

(Firefox for Android Graveyard :: General, defect, P5)

Description

[Wesley Johnston (:wesj)]

I added a new generated JNI method to GeckoAppShell today. Building with 'mach build' gave an error that the method didn't exist. After a bit, I tried just building mobile/android to see if it would fix the problem (using 'make -C mobile/android') and finally saw a 'run this command' message (why do we not just do that for you?). Running that seems to have made the world happy.

This should all just work with no intervention.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

We shouldn't run the command automatically because it potentially clobbers local changes if you have any. But I do agree that the full error message should show up when you run mach build; I don't know why that is different from make -C mobile/android. CC'ing ckitching and gps.

Comment 2

[Chris Kitching [:ckitching]]

Indeed. It's a bit of a kludge. The procedure that works is to annotate the new method in Java, run a build, copy the generated files, then add your C++ code that uses the new C++ method, then build again.

This isn't obvious.

Comment 3

[Firefox Bug Husbandry Bot]

Re-triaging per https://bugzilla.mozilla.org/show_bug.cgi?id=1473195

Needinfo :susheel if you think this bug should be re-triaged.

Comment 4

[Nick Alexander :nalexander [he/him]]

Post Bug 1453417, I think this is no longer an issue.