918449 - Implement UI dropdown language

Status: RESOLVED FIXED

(Webmaker Graveyard :: Login, defect)

Description

[Ali Al Dallal [:alicoding]]

Implement the dropdown language picker for login.

This bug doesn't include the remember language preference at the moment.

Comment 1

[Ali Al Dallal [:alicoding]]

Attachment: https://github.com/mozilla/login.webmaker.org/pull/165

Comment 2

[Kieran Sedgwick (:sedge)]

Comment on attachment 807353 [details] [review]
https://github.com/mozilla/login.webmaker.org/pull/165

I'm gonna hit the R- on this cuz of the tests failing. Fix that and I'll review again.

Comment 3

[Dale Karp (:daleee)]

Comment on attachment 807353 [details] [review]
https://github.com/mozilla/login.webmaker.org/pull/165

Code looks good, tested locally and it didn't seem to blow up with the related wm.org patch. However, as there was only one language, I could not test the persisting of language.

Comment 4

[Kieran Sedgwick (:sedge)]

Comment on attachment 807353 [details] [review]
https://github.com/mozilla/login.webmaker.org/pull/165

Looks good! Get a demo up that we can see.

Comment 5

[[github robot]]

Commit pushed to master at https://github.com/mozilla/login.webmaker.org

https://github.com/mozilla/login.webmaker.org/commit/2943968a43e211ca4eb53855bd26b0424c2fbb5e
bug918449 - implement UI dropdown change language