918490 - Don't show the user message about Publishers to admins accessing /curation

Status: RESOLVED FIXED

(Marketplace Graveyard :: Admin Tools, defect)

Description

[krupa raj[:krupa]]

steps to reproduce:
1. As an admin, load https://marketplace-dev.allizom.org/curation/
2. Notice the user message "In order to create or modify collections, you must be logged in as a Marketplace Publisher to effectively use this tool."


observed behavior:
That user message is not true for admins since they have full access. Let's not show that message to people with access.

Comment 1

[Matt Basta [:basta]]

This happens because you haven't logged in since the publisher permission was added. We only update your local permission list when you log in, so logging out and logging in should fix this. You can log in/out from any commonplace project (fireplace, rocketfuel, new stats, commbadge, etc.).

If you're still having this issue after logging out and back in, reopen please.

Comment 2

[Christopher Van Wiemeersch [:cvan]]

(In reply to krupa raj[:krupa] from comment #0)
> observed behavior:
> That user message is not true for admins since they have full access. Let's
> not show that message to people with access.

Apparently, this isn't true. Adora is an admin and she was unable to use the tool until I asked Jason to explicitly grant her Apps:Publisher privileges.

Sounds like we have a bug.

Comment 3

[Matt Basta [:basta]]

(In reply to Christopher Van Wiemeersch [:cvan] from comment #2)
> (In reply to krupa raj[:krupa] from comment #0)
> > observed behavior:
> > That user message is not true for admins since they have full access. Let's
> > not show that message to people with access.
> 
> Apparently, this isn't true. Adora is an admin and she was unable to use the
> tool until I asked Jason to explicitly grant her Apps:Publisher privileges.
> 
> Sounds like we have a bug.

Did Adora log out and back in?

Comment 4

[Christopher Van Wiemeersch [:cvan]]

(In reply to Matt Basta [:basta] from comment #3)
> (In reply to Christopher Van Wiemeersch [:cvan] from comment #2)
> > (In reply to krupa raj[:krupa] from comment #0)
> > > observed behavior:
> > > That user message is not true for admins since they have full access. Let's
> > > not show that message to people with access.
> > 
> > Apparently, this isn't true. Adora is an admin and she was unable to use the
> > tool until I asked Jason to explicitly grant her Apps:Publisher privileges.
> > 
> > Sounds like we have a bug.
> 
> Did Adora log out and back in?

Yep, I told her to. And she claimed she did.

Comment 5

[krupa raj[:krupa]]

(In reply to Matt Basta [:basta] from comment #1)
> This happens because you haven't logged in since the publisher permission
> was added. We only update your local permission list when you log in, so
> logging out and logging in should fix this. You can log in/out from any
> commonplace project (fireplace, rocketfuel, new stats, commbadge, etc.).
> 
> If you're still having this issue after logging out and back in, reopen
> please.

Logging out and logging back in didn't help.

Comment 6

[Matt Basta [:basta]]

Oh wait, nevermind. Chuck changed the name of the permission coming back from the API and didn't tell anyone.

CHUCK!

https://github.com/mozilla/rocketfuel/commit/724fe0d4ca9a8d75324f30c076f9172747a60b26

Comment 7

[Chuck Harmston [:chuck]]

I totally did tell you: https://github.com/mozilla/zamboni/pull/1098#discussion_r6252469

Comment 8

[Matt Basta [:basta]]

I love how you made an important note about an important change in the middle of a many-dozen comment review for which I get emails about each comment, not just ones where I'm mentioned

Comment 9

[Wil Clouser [:clouserw]]

thanks everyone! :)