Closed
Bug 91882
Opened 23 years ago
Closed 23 years ago
javascript strict warnings in walletTasksOverlay.xul
Categories
(Toolkit :: Form Manager, defect)
Tracking
()
VERIFIED
FIXED
People
(Reporter: bugzilla, Unassigned)
Details
Attachments
(4 files)
1.53 KB,
patch
|
Details | Diff | Splinter Review | |
3.27 KB,
patch
|
Details | Diff | Splinter Review | |
3.81 KB,
patch
|
Details | Diff | Splinter Review | |
4.03 KB,
patch
|
Details | Diff | Splinter Review |
To reproduce: 1) Start Mozilla 2) Start the JavaScript console 3) load http://mozilla.org 4) Select Tasks -> Privacy -> Cookies -> Unblock from this site 5) Switch to the console 6) Select Tasks -> Privacy -> Password Manager Warning: reference to undefined property this.pref Source File: chrome://wallet/content/walletTasksOverlay.xul Line: 45 build 20010721
Comment 1•23 years ago
|
||
I'm wondering why we even have chrome on the javascript consule. But, assuming that there is good reason for having that, at least we shouldn't have the password manager in the task menu of the java console (we already remove the form-manager in that case). Attaching patch that removes the password manager as well as the form manager. cc'ing vishy and blake for reviews.
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla0.9.3
Comment 2•23 years ago
|
||
Comment 3•23 years ago
|
||
Why do we want to remove it? I thought the purpose of the Tasks menu was to be consistent everywhere.
Comment 4•23 years ago
|
||
And the image manager is not to appear in the Netscape product unless told to do so by a hidden pref. But you can't test for prefs when in the javascript console window. So therefore the task menu cannot be the same in the browser and the javascript console. That's why I opted to fix this bug by removing the items. See also bug 91881 where first I tried keeping the items in but quickly ran into trouble.
Comment 5•23 years ago
|
||
If we really want to keep these items in the task menu (in fact, if we really want to keep the task menu) in the js-console window, then here's a patch that fixes the js bugs without changing the menu items. Note that this module already had code in it which removed the form-manager from the task menu when not in the browser window. I believe that that was requested at one time by the mail team (but I'm not sure) because it was causing problems in the mail window. So now if we want to keep the task menu the same in all windows, I must remove that form-manager-removal code. My next patch does that as well.
Comment 6•23 years ago
|
||
Comment 7•23 years ago
|
||
r=vishy
Comment 8•23 years ago
|
||
Comment 9•23 years ago
|
||
should null check pref in some of those places.... sr=blake
Comment 10•23 years ago
|
||
Comment 11•23 years ago
|
||
Fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Updated•16 years ago
|
Assignee: morse → nobody
Product: Core → Toolkit
QA Contact: tpreston → form.manager
Target Milestone: mozilla0.9.3 → ---
Version: Trunk → unspecified
You need to log in
before you can comment on or make changes to this bug.
Description
•