919723 - Error when clearing "Offline website data"

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Brian Nicholson (:bnicholson)]

STR:
1) Go to Settings > Privacy > Clear private data
2) Make sure "Offline website data" is checked
3) Click "Clear data"

An error toast appears along with the following in logcat:
E/GeckoConsole(21093): sanitize error: ReferenceError: LoadContextInfo is not defined

Comment 1

[Brian Nicholson (:bnicholson)]

Attachment: Add missing import to Sanitizer.jsm

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 808863 [details] [diff] [review]
Add missing import to Sanitizer.jsm


>+Cu.import("resource://gre/modules/LoadContextInfo.jsm");

Given this JSM is itself lazily loaded I suppose we could do a straight import

> XPCOMUtils.defineLazyModuleGetter(this, "FormHistory",
>                                   "resource://gre/modules/FormHistory.jsm");

Which makes me wonder if we shouldn't just do it here too?

Comment 3

[Honza Bambas (:mayhemer)]

Ups, thanks for the fix.

Comment 4

[Brian Nicholson (:bnicholson)]

https://hg.mozilla.org/integration/fx-team/rev/c15401b502b4

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/c15401b502b4