919926 - [regression] External accounts not listed in user profile page.

Status: VERIFIED FIXED

(Participation Infrastructure :: Phonebook, defect)

Description

[Giorgos Logiotatidis [:giorgos]]

While resolving conflicts (yikes!)  in the html file profile.html, I missed the accounts part. I'll pull request a fix and also beautify it a bit to make up for my bad.

Comment 1

[[github robot]]

Commits pushed to master at https://github.com/mozilla/mozillians

https://github.com/mozilla/mozillians/commit/2945da823d447889ac513c3c877bece25ee29d44
[fix bug 919926] Re-list external accounts in profile page.

https://github.com/mozilla/mozillians/commit/39a03b8c15cd53cdd40dd9b0c0843259bccba9f7
Merge pull request #628 from glogiotatidis/919926

[fix bug 919926] Re-list external accounts in profile page.

Comment 2

[Matt Brandt [:mbrandt]]

Reopening:

Not sure if this should be a separate bug however external accounts when set as publicly viewable no longer show up in the public facing/non-logged in view.

For example a bugzilla and github account should be publicly viewable on 
https://mozillians.allizom.org/u/mbrandt/

Comment 3

[Matt Brandt [:mbrandt]]

Bumping back to resolved - turns out it is a different issue which I'll file a follow up bug for. Setting all fields as publicly viewable doesn't change the 'External Accounts' settings.

Comment 4

[Matt Brandt [:mbrandt]]

Nicely done, QA verified on stage.