919927 - [Permission] use permissions instead of permission/option/options

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[[e-mail]]

Due to recent refactor, Gecko can returns permissions/options attribute to support multiple permissions. the old permission/option attribute will be deprecated.

We should progressively remove current use of permission/option attribute and use permissions/options instead.

Comment 1

[[e-mail]]

In 1.3, permission/option/options are obsolete, use permissions instead

The format will be 

{
  "video-capture": ['back', 'front'],
  "audio-capture": [""]
}

or 

{
  "geolocation":[]
}


the return value will be 

{
  "video-capture": 'back',
  "audio-capture": ""
}

Comment 2

[[e-mail]]

Attachment: pull request redirect to github

Comment 3

[Jason Smith [:jsmith]]

(In reply to Fred Lin [:gasolin] from comment #1)
> In 1.3, permission/option/options are obsolete, use permissions instead
> 
> The format will be 
> 
> {
>   "video-capture": ['back', 'front'],
>   "audio-capture": [""]
> }
> 
> or 
> 
> {
>   "geolocation":[]
> }
> 
> 
> the return value will be 
> 
> {
>   "video-capture": 'back',
>   "audio-capture": ""
> }

That format is going to completely break compatibility with the existing apps permissions model if that's the case. The typical format is:

{
  "permissions": {
     "contacts": {
       "description": "",
       "access": "readcreate"
     }
  }
}

Which uses a JSON dictionary, not a list. This is because permissions can have multiple attributes - description, access, etc.

Comment 4

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

@jsmith, I think there is a misunderstanding that we are not going to change the permission declaration format in manifest.webapp. This bug is for modifying the parameters in mozChromeEvent/mozContentEvent for the permission prompt. It does not have compatibility issue for existing webapps.

Comment 5

[Jason Smith [:jsmith]]

(In reply to Shih-Chiang Chien [:schien] from comment #4)
> @jsmith, I think there is a misunderstanding that we are not going to change
> the permission declaration format in manifest.webapp. This bug is for
> modifying the parameters in mozChromeEvent/mozContentEvent for the
> permission prompt. It does not have compatibility issue for existing webapps.

Ah okay - makes sense.

Comment 6

[Alfredo Yang (:alfredo)]

Hi Fred,
The gecko patch is at https://bugzilla.mozilla.org/show_bug.cgi?id=853356. Both patches probably need to be checkin together to avoid break.
Thanks.

Comment 7

[[e-mail]]

merged to gaia-master https://github.com/mozilla-b2g/gaia/commit/5289b66509338239e338851a0258fc4e16a028d2

thanks!

Comment 8

[Jason Smith [:jsmith]]

John - Can you back this out? The associated patch this bug is dependent on was backed out, so right now this implementation ends up causing bug 935557 without the dependency present. As a result, the geolocation prompt is broken right now with this patch present.

Comment 9

[John Ford [:jhford] CET/CEST Berlin Time]

Reverted:

[master 6a5cc5d] Revert "Merge pull request #13276 from gasolin/issue-919927"

Comment 10

[John Ford [:jhford] CET/CEST Berlin Time]

Relanded because this revert is breaking travis.

[master 231840c] Revert "Revert "Merge pull request #13276 from gasolin/issue-919927""

Comment 11

[Jason Smith [:jsmith]]

Closing again based on comment 10, although we need to get this backed out cleanly.

Comment 12

[Kevin Grandon :kgrandon]

Backed out of master by request of jsmith here: https://github.com/mozilla-b2g/gaia/commit/f86f7f5c64eb6fd01ab17f721b542e17ed1c9b7e

An additional commit was required to remove the expected failure of the geolocation test: https://github.com/KevinGrandon/gaia/commit/ff6f5189fc2ed9b5419e4155f1dc6cb9ab32bb3b

Comment 13

[[e-mail]]

Attachment: pull request redirect to github 2

cherry-pick bug 919927 with bug 935557 fix, make permission manager backward compatible.

feedback? Zac for functional test part

Comment 14

[Zac C (:zac)]

Comment on attachment 829966 [details] [review]
pull request redirect to github 2

F+ for me and a pass on Travis!

Comment 15

[[e-mail]]

merged to gaia-master https://github.com/mozilla-b2g/gaia/commit/203307c19afa5894f7cd7f52c5f00812b5c24067

thanks!

Comment 16

[Jason Smith [:jsmith]]

This is targeted feature for 1.3, not committed, so we don't need to block on this.