920009 - [User Story] Delete multiple contacts

Status: RESOLVED DUPLICATE of bug 956219

(Firefox OS Graveyard :: Gaia::Contacts, defect, P1)

Description

[Wilfred Mathanaraj [:WDM]]

User story:

As a user I want to be able to select multiple contacts and delete.


Acceptance Criteria:

AC 1: I am offered in any situation where I can delete a contact a possibility to select multiple contacts

Comment 1

[Francisco Jordano [:arcturus] [:francisco]]

Hey Ayman, before starting to work on it would like your input.

My idea here is reuse the select list that we have for exporting, but instead of that for delete.

I'll need some feedback on how the interaction should be. Will prepare a poc so you can take a look.

Thanks!

Comment 2

[Francisco Jordano [:arcturus] [:francisco]]

Hi folks,

prelimiar poc of the multiple delete:

https://github.com/arcturus/gaia/tree/bug-920009

(yes perhaps it has a bug, but at least it's trying to show a possible workflow, always pending from Ayman words)

Thanks!

Comment 3

[ayman maat :maat]

removed the ni? to me by mistake whilst doing some bug admin putting it back.

Comment 4

[Francisco Jordano [:arcturus] [:francisco]]

Attachment: poc running on nightly

Comment 5

[ayman maat :maat]

Comment on attachment 814899 [details]
poc running on nightly

Hey Francisco

Ok, overall in terms of IxD your totally in the ball park with this. There are just three points that I think  need to be tweeked: 

1) I know you have used the export contacts as your working template which is correct, however we need to align the visual treatment of this screen to the Delete interface of the message app as they are functionally related (delete should have the same visual treatment and therefore speak the same visual language everywhere) I will ni? Victoria to provide you with the assets.

2) @ 00:21 : When one or more contacts is selected the header should change its label from 'Contacts' to ''n' selected'. This both keeps the user orientated as to the number of contacts selected when the selected contacts are not visible on the screen, therefore lowering their cognitive loading, and also aligns the 'Selection to Delete' functionality to that in the Messages App and Call Log.

3) @ 00:23 : The last part of the alphabet in the column on the right hand side of the screen is covered by the screens Footer and is therefore not accessible. Victoria should be able to fix this when she produces the Visual Design for you.

…Apart from that it all looks good to me

Comment 6

[ayman maat :maat]

Reference Comment 5

Comment 7

[Victoria Gerchinhoren [:vicky]]

Hi All,

There's no need for Visual Design here as this the deleting action is widely used all across the system. Please use the correct Building Block and you'll have no problem: http://buildingfirefoxos.com/building-blocks/edit-mode.html

Thanks.

Comment 8

[Victoria Gerchinhoren [:vicky]]

Attachment: Visual QA for delete multiple contacts, selection screen

Comment 9

[Victoria Gerchinhoren [:vicky]]

Hey,

There's a bug for solving the index length issue when in edit mode: https://bugzilla.mozilla.org/show_bug.cgi?id=923143

I have attached a detailed exam of the layout implementation based on the video shared. A few things are pointed out. If you have any further question or doubt, please needinfo me.

Comment 10

[David Scravaglieri [:scravag]]

This bug is actively worked but isn't a release blocker, it will land once fixed.

Comment 11

[Joe Cheng [:jcheng] (please needinfo)]

Wilfred, this is not in your excel Google doc comms sheet but it's in your email as targeted. Can you confirm this user story for 1.4 targeted? Thanks

Comment 12

[Wilfred Mathanaraj [:WDM]]

its in google doc - just not following the other sections - its further down the list. Confimred its  target.

Comment 13

[ashayb2g]

Can you please provide the patch for the implementation of multiple delete of contacts, as shown in the video ?

Comment 14

[Francisco Jordano [:arcturus] [:francisco]]

@ashab2g that was a PoC, with some fails, will need to invest some time on it and right now have other committed features.

If I find the time in 1.4 will do it.

Thanks,
F.

Comment 15

[ashayb2g]

@francisco, Can you please provide the work in progress patch ? so that we can take it forward.

Thanks,
Ashay

Comment 16

[Francisco Jordano [:arcturus] [:francisco]]

Sure the work is in a branch here:

https://github.com/arcturus/gaia/tree/bug-920009

It's quite outdated, but easy to follow.

Regards,
F.

Comment 17

[ashayb2g]

Please assign this task to me as I am unable to assign it to myself.

Thanks
Ashay

Comment 18

[ashayb2g]

Attachment: WorkInProgress_MultiContactDelete.patch

Hi Francisco,
   Attaching work in progress patch for Multiple Contact Delete. Please review and let me know your feedback.

Regards
Ashay

Comment 19

[ashayb2g]

Hi Wchang,
   As Francisco is PTO till 11th Jan, Can you please assign some one for patch review and let us know the feedback.

Regards
Ashay

Comment 20

[Wayne Chang [:wchang]]

Jose, maybe you can help?

(In reply to ashayb2g from comment #19)
> Hi Wchang,
>    As Francisco is PTO till 11th Jan, Can you please assign some one for
> patch review and let us know the feedback.
> 
> Regards
> Ashay

Comment 21

[Jose Manuel Cantera]

[e-mail] please could you attach a Github PR in order to properly review your patch?. On the other hand I'm concerned on the changes you have done to navigation.js, are they really necessary? There is code commented as well on your patch ...

Comment 22

[ashayb2g]

@Jose, Please refer https://bugzilla.mozilla.org/show_bug.cgi?id=956219 as an implementation of Multiple Contact Delete. PR is attached in this bug request.

Regarding navigation.js, on Multiple Delete screen it was not getting the proper zIndex because of two navigation stack.

Comment 24

[David Scravaglieri [:scravag]]

This is a target for 1.4