Closed Bug 920180 Opened 11 years ago Closed 11 years ago

Update the gaia-ui endurance settings and sms tests for master; update manifest

Categories

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::UI Tests
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: rwood, Assigned: rwood)

Details

Attachments

(1 file)

pull request pointer
46 bytes, text/x-github-pull-request
davehunt
: review+
Details | Review 
Updates to the gaia-ui endurance tests (settings and sms tests) for latest changes in master; includes addition to the gaiatest messages app; update manifest.
Attached file pull request pointer — 

        Attachment #809366 -
        Flags: review?(bob.silverberg)

    
    

    
  
:bsilverberg, requesting a review of the addition to the gaiatest message app, thanks!

    
    

    
  
Comment on attachment 809366 [details] [review]
pull request pointer

I have added me comments to the PR.

        Attachment #809366 -
        Flags: review?(bob.silverberg) → review-

    
  

        Attachment #809366 -
        Flags: review- → review?(bob.silverberg)

    
    

    
  
Comment on attachment 809366 [details] [review]
pull request pointer

Comments in the pull request.

        Attachment #809366 -
        Flags: review?(bob.silverberg) → review-

    
  

        Attachment #809366 -
        Flags: review- → review?(bob.silverberg)

    
    

    
  
Comment on attachment 809366 [details] [review]
pull request pointer

Comments in the PR.

        Attachment #809366 -
        Flags: review?(bob.silverberg) → review-

    
    

    
  
Comment on attachment 809366 [details] [review]
pull request pointer

Updated the pull request

        Attachment #809366 -
        Flags: review- → review?(bob.silverberg)

    
    

    
  
Comment on attachment 809366 [details] [review]
pull request pointer

My last comment was just a question. The PR gets my r+ either way. For the changes to the app objects that is.

        Attachment #809366 -
        Flags: review?(bob.silverberg) → review+

    
    

    
  
Comment on attachment 809366 [details] [review]
pull request pointer

Thanks Bob.

Dave, would you mind doing a quick review of the rest of the changes in the pull request? Thanks!

        Attachment #809366 -
        Flags: review+ → review?(dave.hunt)

    
    

    
  
Comment on attachment 809366 [details] [review]
pull request pointer

One minor PEP8 issue, but you can carry my r+
Please squash your commits before merging.

        Attachment #809366 -
        Flags: review?(dave.hunt) → review+

    
    

    
  
Thanks Dave. Squashed and merged.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Attachment mime type: text/plain → text/x-github-pull-request

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: