920718 - B2G desktop mochitests broken from bug 746243

Status: RESOLVED FIXED

(Testing :: Mochitest, defect)

Description

[Andrew Halberstadt [:ahal]]

Bug 746243 removes automation.py from desktop mochitests, but this breaks the b2g desktop mochitests which still depend on it. I noticed this while I was in the process of getting them running in automation so this doesn't happen in the future :)

Patch coming shortly.

Comment 1

[Andrew Halberstadt [:ahal]]

Attachment: Patch 1.0 - fix bustage

This gets things working again.

The only comment I have is using "appname" to figure out which Runner class to use. In b2g the preferred method of detection is "toolkit" == "gonk" to account for b2g desktop or other branding. But b2g mochitests don't use this function at all so for now I think this patch is good enough.

Comment 2

[Jeff Hammel]

Comment on attachment 810145 [details] [diff] [review]
Patch 1.0 - fix bustage

Review of attachment 810145 [details] [diff] [review]:
-----------------------------------------------------------------

if it passes locally, lgtm

Comment 3

[Andrew Halberstadt [:ahal]]

https://hg.mozilla.org/integration/b2g-inbound/rev/03ee2343b34e

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/03ee2343b34e