Closed Bug 921056 Opened 11 years ago Closed 11 years ago

Call Status Bar. Polish layout

Categories

(Firefox OS Graveyard :: Gaia::Dialer, defect)

x86
macOS
defect
Not set
normal

Tracking

(blocking-b2g:koi+, b2g-v1.2 fixed)

VERIFIED FIXED
blocking-b2g koi+
Tracking Status
b2g-v1.2 --- fixed

People

(Reporter: vicky, Assigned: rik)

References

Details

(Whiteboard: [u=commsapps-user c=dialer p=0] burirun2)

Attachments

(7 files, 1 obsolete file)

Call status bar implementation needs polish. Please follow this designs and specs
Attached image SPECS callstatusBar
Whiteboard: [u=commsapps-user c=dialer p=0]
Requesting koi? because this is about finishing the conference call user story. I'll work on it alongside bug 918534.
Assignee: nobody → anthony
Blocks: 908679
blocking-b2g: --- → koi?
No longer blocks: comms_1.3_targeted
We can't do the translucent bar for the moment because the apps are being resized to not be under the double-sized status bar. If we did translucent, pixels 1-20 would be the status bar, pixels 21-40 would be the phone background. Is it ok with a full black?

BTW, it's really useful to see the values of the spacing, fonts, color values.
Hi Anthony,
Thats a good point. Full black doesn't sound the best option, if it needs to be opaque, please use #333333 (our darkest grey) as background color.

Thanks!
V
should this be a meta bug with smaller bug created per screenshot?
Summary: Call Status Bar. Polish layout → [Meta] Call Status Bar. Polish layout
blocking-b2g: koi? → ---
Depends on: 923052
Attachment #810615 - Attachment is obsolete: true
Depends on: 923053
Depends on: 923020
For this particular bug, it's actually easier to work with only one bug so I'll gather all resources in this one and close the other bugs.
blocking-b2g: --- → koi?
No longer depends on: 923020, 923052, 923053
Summary: [Meta] Call Status Bar. Polish layout → Call Status Bar. Polish layout
Attachment #813630 - Flags: review?(etienne)
Comment on attachment 813630 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/12658

r=me with the small naming nit addressed.
Attachment #813630 - Flags: review?(etienne) → review+
https://github.com/mozilla-b2g/gaia/commit/f1c62186e214febd92b72c148289c48b4bcff204
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [u=commsapps-user c=dialer p=0] → [u=commsapps-user c=dialer p=0] burirun2
Not a release block, please ask for approval.
Flags: needinfo?(anthony)
Removing koi? flag per comment 19
blocking-b2g: koi? → ---
Re-requesting koi+ since the status bar is in a very bad shape without this patch as can be seen in attachment 807469 [details].
blocking-b2g: --- → koi?
Flags: needinfo?(anthony)
blocking-b2g: koi? → ---
rik - I'm confused here. The bug you duped to this is a blocker, but this isn't. How are we intending to fix bug 914917 if this isn't a blocker?
Jason: I re-requested koi+ in comment 21 but with whatever magic voodoo, I cancelled that request 2 hours later… So I'm re-re-requesting :)
blocking-b2g: --- → koi?
(In reply to Anthony Ricaud (:rik) from comment #24)
> Jason: I re-requested koi+ in comment 21 but with whatever magic voodoo, I
> cancelled that request 2 hours later… So I'm re-re-requesting :)

Glitch with this weekends tracking flag migration on BMO that cause some flags to be cleared when duping bugs. Thanks for putting the flag back right for us.

dkl
blocking-b2g: koi? → koi+
oups mistake back to koi?
blocking-b2g: koi+ → koi?
blocking-b2g: koi? → koi+
Uplifted f1c62186e214febd92b72c148289c48b4bcff204 to:
v1.2: 30943bc9ba7c0eb4fb1859f62c4168c90e3f0831
Checked with Victoria.
Call status bar is shown correctly now.

Verified on 10/25 v1.2 build:
Gecko-9150851
Gaia-606517c
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: