921342 - Compiler warning: not enough actual parameters for macro 'ENSURE_NOT_CHILD_PROCESS_

Status: RESOLVED FIXED

(Core :: Networking: Cookies, defect)

Description

[Mark Hammond [:markh] [:mhammond]]

Attachment: 0001-Bug-XXX-fix-compiler-warning-about-not-enough-args-t.patch

A trivial problem, but still worth fixing IMO.

3:43.35 Warning: C4003 in o:\src\mozilla-git\central2\extensions\cookie\nsPermissionManager.cpp: not enough actual parameters for macro 'ENSURE_NOT_CHILD_PROCESS_'
 3:43.35 o:/src/mozilla-git/central2/extensions/cookie/nsPermissionManager.cpp(1683) : warning C4003: not enough actual parameters for macro 'ENSURE_NOT_CHILD_PROCESS_'

Attaching a trivial fix which seems to work on all platforms: https://tbpl.mozilla.org/?tree=Try&rev=83f1fa4e659a

Flagging Benjamin for review as blame says he is the most recent author of non-trivial changes in that file.

Comment 1

[Mark Hammond [:markh] [:mhammond]]

(In reply to Mark Hammond (:markh) from comment #0)
> Attaching a trivial fix which seems to work on all platforms:
> https://tbpl.mozilla.org/?tree=Try&rev=83f1fa4e659a

Doh - that's an opt-only try.  Debug-only one at https://tbpl.mozilla.org/?tree=Try&rev=3976efa049d3

Comment 2

[Mark Hammond [:markh] [:mhammond]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5ba6768e46fe

Comment 3

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/5ba6768e46fe