Closed Bug 921422 Opened 11 years ago Closed 11 years ago

B2G RIL: include clientId in async messages from RadioInterface to RILContentHelper

Categories

(Firefox OS Graveyard :: RIL, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(blocking-b2g:1.3+, firefox28 fixed)

RESOLVED FIXED
1.3 Sprint 2 - 10/11
blocking-b2g 1.3+
Tracking Status
firefox28 --- fixed

People

(Reporter: jessica, Assigned: hsinyi)

References

Details

Attachments

(1 file)

RadioInterfaceLayer sendWithIPCMessage() [1] only sends the content of "msg.json.data" to RILContentHelper, so clientId is missing. We should wrap clientId and data together and sent it back to RILContentHelper.
This affects all the functions that use sendWithIPCMessage(). 

[1] http://mxr.mozilla.org/mozilla-central/source/dom/system/gonk/RadioInterfaceLayer.js#638
Blocks: 818353
Blocks: 818351, 818352
Looks like replacing msg.json.data in [1] with msg.json could fix this issue. 
Will try it later :P

[1] http://mxr.mozilla.org/mozilla-central/source/dom/system/gonk/RadioInterfaceLayer.js#639
Summary: B2G RIL: include clientId in callback messages from RadioInterface to RILContentHelper → B2G RIL: include clientId in async messages from RadioInterface to RILContentHelper
Attached patch 921422.patchSplinter Review
Assignee: nobody → htsai
Attachment #811782 - Flags: review?(vyang)
Attachment #811782 - Flags: review?(vyang)
Attachment #811782 - Flags: review?(vyang)
Attachment #811782 - Flags: review?(vyang) → review+
https://tbpl.mozilla.org/?tree=Try&rev=c9aa690a355a looks green except test_icc_contacts.js which has been tracked in Bug 897940. I ran test_icc_contacts.js locally without encountering failures. 

If I take the suggestion from bug 897940 comment 2, the test passes! https://tbpl.mozilla.org/?tree=Try&rev=b9a57895b831
https://hg.mozilla.org/mozilla-central/rev/a7a6db5c2601
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Blocks: 926343
blocking-b2g: --- → 1.3+
Target Milestone: --- → 1.3 Sprint 2 - 10/11
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: