Closed
Bug 921512
Opened 11 years ago
Closed 10 years ago
Properly document layers code
Categories
(Core :: Graphics: Layers, defect)
Tracking
()
RESOLVED
DUPLICATE
of bug 861377
People
(Reporter: nical, Unassigned)
Details
(Whiteboard: [leave open])
Attachments
(1 file)
6.52 KB,
patch
|
bjacob
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Reporter | ||
Comment 1•11 years ago
|
||
Attachment #811174 -
Flags: review?(bjacob)
Reporter | ||
Updated•11 years ago
|
Whiteboard: [leave open]
Comment 2•11 years ago
|
||
Comment on attachment 811174 [details] [diff] [review] Document a few more texture client methods Review of attachment 811174 [details] [diff] [review]: ----------------------------------------------------------------- ::: gfx/layers/client/TextureClient.h @@ +125,5 @@ > virtual TextureClientSurface* AsTextureClientSurface() { return nullptr; } > virtual TextureClientYCbCr* AsTextureClientYCbCr() { return nullptr; } > > + /** > + * Always lock/unlock when accessing the shared data. It is not clear if that is a statement about what that method does, or general advice to the reader. @@ +126,5 @@ > virtual TextureClientYCbCr* AsTextureClientYCbCr() { return nullptr; } > > + /** > + * Always lock/unlock when accessing the shared data. > + * if Lock() returns false, do not attempt to access the shared data. Same. @@ +142,3 @@ > > + /** > + * An ID that is used to match a texture client with his corresponding TextureHost. This refers to 'an id' which would be a piece of data, but here we have a method. @@ +142,4 @@ > > + /** > + * An ID that is used to match a texture client with his corresponding TextureHost. > + * Only the COmpositableClient should be allowed to set or clear the ID. CO with uppercase O
Attachment #811174 -
Flags: review?(bjacob) → review+
Reporter | ||
Comment 3•11 years ago
|
||
fixed comments and landed https://hg.mozilla.org/integration/mozilla-inbound/rev/b4a1b2767689
Comment 4•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/b4a1b2767689
Comment 5•11 years ago
|
||
(In reply to Nicolas Silva [:nical] from comment #3) > fixed comments and landed > https://hg.mozilla.org/integration/mozilla-inbound/rev/b4a1b2767689 1.12 -// A texture host that supports tiling 1.13 const TextureFlags TEXTURE_FRONT = 1 << 12; That doesn't look like adding documentation.
Flags: needinfo?(nobody)
Reporter | ||
Comment 6•11 years ago
|
||
(In reply to :Ms2ger from comment #5) > (In reply to Nicolas Silva [:nical] from comment #3) > > fixed comments and landed > > https://hg.mozilla.org/integration/mozilla-inbound/rev/b4a1b2767689 > > 1.12 -// A texture host that supports tiling > 1.13 const TextureFlags TEXTURE_FRONT = 1 << 12; > > That doesn't look like adding documentation. Yeah, that comment was just wrong. Looks like a copy-past accident. The change was too small to get its own patch though.
Reporter | ||
Updated•10 years ago
|
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•