921584 - When compiling ProxyObject.cpp: "Runtime.h:1434:17: warning: inline function 'bool JSRuntime::isAtomsZone(JS::Zone*)' used but never defined [enabled by default]"

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Daniel Holbert [:dholbert]]

Build warning noticed today, when compiling mozilla-inbound:
{
In file included from /mozilla-inbound/js/src/jscntxt.h:15:0,
                 from /mozilla-inbound/js/src/gc/Zone.h:13,
                 from /mozilla-inbound/js/src/jsgcinlines.h:12,
                 from /mozilla-inbound/js/src/vm/ProxyObject.cpp:9:
/mozilla-inbound/js/src/vm/Runtime.h:1434:17: warning: inline function 'bool JSRuntime::isAtomsZone(JS::Zone*)' used but never defined [enabled by default]
     inline bool isAtomsZone(JS::Zone *zone);
                 ^
}

Comment 1

[Daniel Holbert [:dholbert]]

hg bisect says this was introduced by:
{
changeset:   148911:5b35eb07b456
user:        Ehsan Akhgari <[e-mail]>
date:        Thu Sep 26 18:34:54 2013 -0400
summary:     Bug 921130 - Minimize the #includes in js/src/jit; r=luke
}
http://hg.mozilla.org/mozilla-central/rev/5b35eb07b456

Comment 2

[(no longer active)]

Attachment: Patch (v1)

Comment 3

[Boris Zbarsky [:bzbarsky]]

See bug 921583?

Comment 5

[Nicholas Nethercote [inactive]]

Comment on attachment 811341 [details] [diff] [review]
Patch (v1)

Review of attachment 811341 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jscompartment.h
@@ +20,5 @@
>  }
>  
> +namespace gc {
> +template<class Node> class ComponentFinder;
> +}

Is this necessary?  Maybe it avoids some bootlegging?  We generally don't worry about bootlegging much -- it's so hard to avoid -- but it's not a big deal either way.

Comment 6

[(no longer active)]

(In reply to comment #5)
> Comment on attachment 811341 [details] [diff] [review]
>   --> https://bugzilla.mozilla.org/attachment.cgi?id=811341
> Patch (v1)
> 
> Review of attachment 811341 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: js/src/jscompartment.h
> @@ +20,5 @@
> >  }
> >  
> > +namespace gc {
> > +template<class Node> class ComponentFinder;
> > +}
> 
> Is this necessary?  Maybe it avoids some bootlegging?  We generally don't worry
> about bootlegging much -- it's so hard to avoid -- but it's not a big deal
> either way.

I wrote several versions of this patch locally, and this was required in one of them.  It's kind of more correct to do the fwd declaration here since the header references ComponentFinder, so I'd prefer to leave it in.

At any rate, I'll land this patch if inbound ever reopens.

Comment 7

[(no longer active)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/632e32739bc5

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/632e32739bc5