Closed Bug 922182 Opened 11 years ago Closed 11 years ago

Fix trending apps

Categories

(Marketplace Graveyard :: Statistics, defect, P3)

Product:
Marketplace Graveyard
Component:
Statistics
Version:
Avenir
Platform:
x86
macOS
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
2013-10-14

People

(Reporter: robhudson, Assigned: robhudson)

Details

(Whiteboard: [qa-]) 

I'm not sure of the exact reason but a recent run of the cron on -dev tracebacks. Looks like we need to be more careful with what data comes back from Monolith.

$ ./manage.py --settings=settings_local_mkt cron update_app_trending
Traceback (most recent call last):
  File "./manage.py", line 134, in <module>
    execute_manager(settings)
  File "/data/addons-dev/www/addons-dev.allizom.org/deploy-zamboni-dev-20130930091641-765736e5d1/venv/lib/python2.6/site-packages/django/core/management/__init__.py", line 459, in execute_manager
    utility.execute()
  File "/data/addons-dev/www/addons-dev.allizom.org/deploy-zamboni-dev-20130930091641-765736e5d1/venv/lib/python2.6/site-packages/django/core/management/__init__.py", line 382, in execute
    self.fetch_command(subcommand).run_from_argv(self.argv)
  File "/data/addons-dev/www/addons-dev.allizom.org/deploy-zamboni-dev-20130930091641-765736e5d1/venv/lib/python2.6/site-packages/django/core/management/base.py", line 196, in run_from_argv
    self.execute(*args, **options.__dict__)
  File "/data/addons-dev/www/addons-dev.allizom.org/deploy-zamboni-dev-20130930091641-765736e5d1/venv/lib/python2.6/site-packages/django/core/management/base.py", line 232, in execute
    output = self.handle(*args, **options)
  File "/data/addons-dev/www/addons-dev.allizom.org/deploy-zamboni-dev-20130930091641-765736e5d1/venv/lib/python2.6/site-packages/cronjobs/management/commands/cron.py", line 64, in handle
    registered[script](*args)
  File "/data/addons-dev/www/addons-dev.allizom.org/deploy-zamboni-dev-20130930091641-765736e5d1/zamboni/mkt/webapps/cron.py", line 103, in update_app_trending
    value = _get_trending(app.id)
  File "/data/addons-dev/www/addons-dev.allizom.org/deploy-zamboni-dev-20130930091641-765736e5d1/zamboni/mkt/webapps/cron.py", line 79, in _get_trending
    client('app_installs', days_ago(7), today, 'week', **kwargs))
TypeError: unsupported operand type(s) for +: 'int' and 'NoneType'
https://github.com/mozilla/zamboni/commit/f8d3d264
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [qa-]
Target Milestone: --- → 2013-10-14
You need to log in before you can comment on or make changes to this bug.