Closed
Bug 922329
Opened 11 years ago
Closed 11 years ago
HelperApps.getAppsForUri does not check for empty results and throws
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox25 unaffected, firefox26 fixed, firefox27 fixed, fennec26+)
RESOLVED
FIXED
Firefox 27
Tracking | Status | |
---|---|---|
firefox25 | --- | unaffected |
firefox26 | --- | fixed |
firefox27 | --- | fixed |
fennec | 26+ | --- |
People
(Reporter: mfinkle, Assigned: mfinkle)
References
Details
Attachments
(1 file)
1.20 KB,
patch
|
wesj
:
review+
lsblakk
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
We assume that "Intent:GetHandlers" will always work, but GeckoView does not implement it, and may never implement it. This causes the JSON.parse to throw and breaks the initialization of many other parts of code. Effectively killing GeckoView. In the long term, I want to split out code from browser.js into 3 code paths: * Firefox (default) * WebApp * GeckoView Some parts of the code won't be needed for WebApps and GeckoView, so let's not even add it. In the meantime, this fixes the current problem. With this patch, GeckoView example apps work on everything but the Nexus 4 (bug 921792)
Attachment #812258 -
Flags: review?(wjohnston)
Comment 1•11 years ago
|
||
Comment on attachment 812258 [details] [diff] [review] Check for valid return data Review of attachment 812258 [details] [diff] [review]: ----------------------------------------------------------------- ::: mobile/android/chrome/content/HelperApps.js @@ +60,5 @@ > packageName: "", > className: "" > }; > + let data = sendMessageToJava(msg); > + if (data) { Early return instead?
Attachment #812258 -
Flags: review?(wjohnston) → review+
Assignee | ||
Comment 2•11 years ago
|
||
(In reply to Wesley Johnston (:wesj) from comment #1) > > + let data = sendMessageToJava(msg); > > + if (data) { > > Early return instead? OK https://hg.mozilla.org/integration/fx-team/rev/dd3dd64aa432
Comment 3•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/dd3dd64aa432
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 27
Comment 5•11 years ago
|
||
This fix needs uplift to Aurora.
Updated•11 years ago
|
tracking-firefox26:
--- → ?
Comment 6•11 years ago
|
||
Err...wrong flag. Apologize for bugspam.
tracking-fennec: --- → ?
tracking-firefox26:
? → ---
Assignee | ||
Comment 7•11 years ago
|
||
Comment on attachment 812258 [details] [diff] [review] Check for valid return data [Approval Request Comment] Bug caused by (feature/regressing bug #): User impact if declined: things like bug 920544 Testing completed (on m-c, etc.): landed and working OK Risk to taking this patch (and alternatives if risky): low risk. we just check for empty data. String or IDL/UUID changes made by this patch: none When uplifting, please use the checked in patch since it is more simple: https://hg.mozilla.org/mozilla-central/rev/dd3dd64aa432
Attachment #812258 -
Flags: approval-mozilla-aurora?
Updated•11 years ago
|
Attachment #812258 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 8•11 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/0857b261c4e1
Assignee: nobody → mark.finkle
Updated•11 years ago
|
tracking-fennec: ? → 26+
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•