Closed
Bug 922577
Opened 11 years ago
Closed 7 years ago
Attributes may leak localizations on language change
Categories
(L20n :: HTML Bindings, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Next
People
(Reporter: stas, Assigned: stas)
References
Details
Attachments
(1 file)
This is a regression from bug 921169. If language A defines <foo "Foo A" title: "Bar A"> and language B defines <foo "Foo B"> without the title attribute, the DOM localization logic introduces in bug 921169 will not remove the "Bar A" title attribute from the element when the language is switched from A to B.
Updated•11 years ago
|
Target Milestone: --- → Next
Assignee | ||
Comment 2•7 years ago
|
||
No, it's not. I added a test to codify the current behavior: https://github.com/projectfluent/fluent.js/commit/e49e23729a45eae771ca653efa8a2822fd272efd I think one way of fixing this would be to never take ALLOWED_ATTRIBUTES from the sourceElement. I'll see if I can come up with a patch.
Flags: needinfo?(stas)
Assignee | ||
Comment 3•7 years ago
|
||
Updated•7 years ago
|
Attachment #8905012 -
Flags: review?(gandalf) → review+
Assignee | ||
Comment 4•7 years ago
|
||
Thanks for the r+. I merged this in https://github.com/projectfluent/fluent.js/commit/64ef2120b9f0203d73e1a62e97baf4d7cd9fbb1e
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•