922981 - Split marDownload.js into individual tests

Status: RESOLVED FIXED

(Toolkit :: Application Update, defect)

Description

[Robert Strong (they/them - no direct email)]

This is one of the longer running app update xpcshell tests and now that xpcshell tests are run in parallel by default I'm going to split the tests into separate tests.

Comment 1

[Robert Strong (they/them - no direct email)]

This test takes as long as 20 seconds on my system while all the other tests take less than a second.

Comment 2

[Robert Strong (they/them - no direct email)]

On Linux x64 Opt 

Slowest test is test_0030_general.js at 10588.650ms

Second slowest test is test_0010_timermanager.js at 6853.222ms which tests a bunch of timer notifications

Third slowest test is test_0113_general.js 3261.155ms which applies a complete mar with update staging

Comment 3

[Robert Strong (they/them - no direct email)]

Attachment: patch rev1

Pushed to try
https://tbpl.mozilla.org/?tree=Try&rev=9eb39e8926ab

Comment 4

[Robert Strong (they/them - no direct email)]

Pushed to fx-team
https://hg.mozilla.org/integration/fx-team/rev/ba3ac8b3853c

Comment 5

[Robert Strong (they/them - no direct email)]

Linux x64 Opt
Before:
downloadMar.js 10395.207ms

After:
downloadAndHashCheckMar.js 3731.356ms
downloadInterruptedRecovery.js 8034.864ms

Windows 7 Opt
Before:
downloadMar.js 22056.000ms

After:
downloadAndHashCheckMar.js 18174.000ms
downloadInterruptedRecovery.js 14478.000ms

Times could be further improved upon... perhaps if time permits

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ba3ac8b3853c