Closed
Bug 923188
Opened 11 years ago
Closed 11 years ago
disable-webgl build failure: HTMLCanvasElement.cpp:417:96: error: invalid use of incomplete type ‘class gfxImageSurface’
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
mozilla27
People
(Reporter: dholbert, Assigned: dholbert)
References
Details
Attachments
(1 file)
|
1000 bytes,
patch
|
ehsan.akhgari
:
review+
|
Details | Diff | Splinter Review |
In a debug build with "ac_add_options --disable-webgl":
{
content/html/content/src/HTMLCanvasElement.cpp:417:96: error: invalid use of incomplete type ‘class gfxImageSurface’
}
(I believe this is what mayhemer was talking about in bug 921753 comment 14.)
Just needs an #include.
|
Assignee | |
Comment 1•11 years ago
|
||
mayhemer, does this fix your build?
|
|
Assignee | |
Comment 2•11 years ago
|
||
Comment on attachment 813169 [details] [diff] [review] fix In any case, I confirmed that this allowed me to build with --disable-webgl. ehsan, want to rubber-stamp?
Attachment #813169 -
Flags: review?(ehsan)
|
||
Comment 3•11 years ago
|
||
Comment on attachment 813169 [details] [diff] [review] fix Review of attachment 813169 [details] [diff] [review]: ----------------------------------------------------------------- A patch of a 1000 bytes. Magical!
Attachment #813169 -
Flags: review?(ehsan) → review+
|
|
Assignee | |
Comment 4•11 years ago
|
||
Thanks! Landed: https://hg.mozilla.org/integration/mozilla-inbound/rev/de230ed86e9c
Flags: in-testsuite-
|
|
Assignee | |
Updated•11 years ago
|
Attachment #813169 -
Flags: review?(honzab.moz)
|
||
Comment 5•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/de230ed86e9c
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
|
||
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•